Rewrite functions from WebPasswordFormData and WebPasswordFormUtils in

Rewrite functions from WebPasswordFormData and WebPasswordFormUtils in
password_form_conversion_utils.

There are Some old Blink code implemented in Webkit that predates the
Chromium/WebKit API, specifically WebPasswordFormData and WebPasswordFormUtils. At
this point the split just makes this code harder to update, as you need to wait
for a Blink roll when adding a new element to autofill::PasswordForm. This patch is
re-writing this code in components/autofill/content/renderer/password_form_conversion_util
s to make it cleaner.

BUG=None

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266438

[ziran.sun, 2014-04-23 17:34:04]

Previous commit has caused memory leak and been reverted - 

http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Te...

Added Fixes in. Please review. Thanks!

[Garrett Casto, 2014-04-23 18:41:17]

Thanks for fixing this.

https://codereview.chromium.org/249153002/diff/20001/components/autofill/cont...
File components/autofill/content/renderer/password_form_conversion_utils.cc
(right):

https://codereview.chromium.org/249153002/diff/20001/components/autofill/cont...
components/autofill/content/renderer/password_form_conversion_utils.cc:167: bool
InitPasswordFormFromWebFormElement(
It doesn't seem like this function is particularly useful, how about just
merging it into CreatePasswordForm?

https://codereview.chromium.org/249153002/diff/20001/components/autofill/cont...
components/autofill/content/renderer/password_form_conversion_utils.cc:194:
return scoped_ptr<PasswordForm>(password_form.release());
return password_form;

[ziran.sun, 2014-04-24 10:24:20]

Code updated as per review comments. Please review. Thanks!

https://codereview.chromium.org/249153002/diff/20001/components/autofill/cont...
File components/autofill/content/renderer/password_form_conversion_utils.cc
(right):

https://codereview.chromium.org/249153002/diff/20001/components/autofill/cont...
components/autofill/content/renderer/password_form_conversion_utils.cc:194:
return scoped_ptr<PasswordForm>(password_form.release());
On 2014/04/23 18:41:17, Garrett Casto wrote:
> return password_form;

When using "return password_form", MOVE_ONLY_TYPE_FOR_CPP_03(scoped_ptr, RValue)
(Line 311 in scoped_ptr.h) throws  "error: ‘scoped_ptr<T,
D>::scoped_ptr(scoped_ptr<T, D>&) [with T = autofill::PasswordForm, D =
base::DefaultDeleter<autofill::PasswordForm>, scoped_ptr<T, D> =
scoped_ptr<autofill::PasswordForm>]’ is private".

Looking into code, it looks that .Pass() is required. Let me know if I missed
anything though.

[Garrett Casto, 2014-04-24 19:11:06]

lgtm

[commit-bot: I haz the power, 2014-04-24 21:49:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ziran.sun@samsung.com/249153002/40001

[commit-bot: I haz the power, 2014-04-24 23:05:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-24 23:05:10]

Try jobs failed on following builders:
  tryserver.chromium on win_chromium_rel

[ziran.sun, 2014-04-25 12:56:46]

The CQ bit was checked by ziran.sun@samsung.com

[commit-bot: I haz the power, 2014-04-25 21:44:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ziran.sun@samsung.com/249153002/40001

[commit-bot: I haz the power, 2014-04-26 06:29:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-26 06:29:13]

The commit queue went berserk retrying too often for a
seemingly flaky test on builder android_dbg:
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...

[ziran.sun, 2014-04-27 16:46:54]

The CQ bit was checked by ziran.sun@samsung.com

[commit-bot: I haz the power, 2014-04-27 16:47:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ziran.sun@samsung.com/249153002/40001

[commit-bot: I haz the power, 2014-04-28 06:03:10]

Change committed as 266438