Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 2491523002: Revert of Treat std::atomic_int as a trivial class member when checking for non-trivial classes. (Closed)

Created:
4 years, 1 month ago by Nico
Modified:
4 years, 1 month ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Treat std::atomic_int as a trivial class member when checking for non-trivial classes. (patchset #2 id:20001 of https://codereview.chromium.org/2483973003/ ) Reason for revert: This broke all clang tot bots, e.g. here: https://build.chromium.org/p/chromium.fyi/builders/ClangToTLinux%20%28dbg%29/builds/4709/steps/gclient%20runhooks/logs/stdio Testing trivial_ctor.cpp... failed: no expected file found ... Ran 18 tests: 17 succeeded, 1 failed trivial_ctor Original issue's description: > Treat atomic_int as a trivial class member when checking for non-trivial classes. > > This is a quick hack to unblock work on > https://codereview.chromium.org/2484803003. The real fix will be to check the > class after template instantiation. > > BUG=663463 > > Committed: https://crrev.com/9d17488d4ed2bfecab3d6e723881e1d9cedfb90a > Cr-Commit-Position: refs/heads/master@{#430773} TBR=dcheng@chromium.org,erg@chromium.org,palmer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=663463 Committed: https://crrev.com/11cb6892af5990d0e4430a8624d5643a1d658d46 Cr-Commit-Position: refs/heads/master@{#430930}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -64 lines) Patch
M tools/clang/plugins/FindBadConstructsConsumer.cpp View 1 chunk +2 lines, -6 lines 0 comments Download
D tools/clang/plugins/tests/trivial_ctor.h View 1 chunk +0 lines, -33 lines 0 comments Download
D tools/clang/plugins/tests/trivial_ctor.cpp View 1 chunk +0 lines, -22 lines 0 comments Download
M tools/clang/plugins/tests/virtual_bodies.h View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Nico
Created Revert of Treat std::atomic_int as a trivial class member when checking for non-trivial classes.
4 years, 1 month ago (2016-11-09 15:05:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2491523002/1
4 years, 1 month ago (2016-11-09 15:05:12 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-09 15:06:01 UTC) #5
commit-bot: I haz the power
4 years, 1 month ago (2016-11-09 15:08:11 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/11cb6892af5990d0e4430a8624d5643a1d658d46
Cr-Commit-Position: refs/heads/master@{#430930}

Powered by Google App Engine
This is Rietveld 408576698