Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 2491513003: WebRTC: Fallback for working_dir in symlink cleaning (Closed)

Created:
4 years, 1 month ago by kjellander_chromium
Modified:
4 years, 1 month ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

WebRTC: Fallback for working_dir in symlink cleaning The solution for the symlink cleaning in https://codereview.chromium.org/2494663002/ doesn't seem to have the desired effect (the checkout being used isn't found). Change back to the previous solution but add a fallback for recipes not using the remote_run way of setting up the directory hierarchy on the bot machine. BUG=663278 TBR=ehmaldonado@chromium.org TESTED= Ran scripts/slave/recipe_modules/webrtc/resources/cleanup_symlinks.py with and without argument to ensure no syntax errors. Committed: https://chromium.googlesource.com/chromium/tools/build/+/cad2afbfe798451f2b0bad1b379d14ff9f8c3577

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -18 lines) Patch
M scripts/slave/recipe_modules/webrtc/api.py View 1 chunk +3 lines, -1 line 0 comments Download
M scripts/slave/recipe_modules/webrtc/resources/cleanup_symlinks.py View 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_android32_asan__l_nexus6_.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_android32_builder.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_android32_release__swarming_.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_android32_tests__j_nexus4_.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_android32_tests__k_nexus5_.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_android32_tests__l_nexus6_.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_linux64_gcc.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_linux_asan__swarming_.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_linux_memcheck__swarming_.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_linux_msan__swarming_.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_linux_tsan_v2__swarming_.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_linux_ubsan__swarming_.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_linux_ubsan_vptr__swarming_.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_mac64_release__swarming_.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_win64_debug__swarming_.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_win64_debug__win10_.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_win64_debug__win8_.json View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
kjellander_chromium
Another try.. I'm glad these are FYI bots.
4 years, 1 month ago (2016-11-10 08:04:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2491513003/1
4 years, 1 month ago (2016-11-10 08:04:15 UTC) #4
commit-bot: I haz the power
4 years, 1 month ago (2016-11-10 08:13:37 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/cad2afbfe798451f2b0b...

Powered by Google App Engine
This is Rietveld 408576698