Fix root ServerWindow size.

Fix root ServerWindow size.

The root ServerWindow was changed to be created using physical pixel
size. When the root ServerWindow gets updated however it was still using
DIP size.

Use physical pixel size instead of DIP size. Also, don't need to check
if root_ exists, as it is initialized in the constructor, so should
always be there.

BUG=659673
Committed: https://crrev.com/47a013537bc0f554137b3ac2db6ce7762ff624f6
Cr-Commit-Position: refs/heads/master@{#431104}

[kylechar, 2016-11-09 20:15:12]

kylechar@chromium.org changed reviewers:
+ msw@chromium.org

[msw, 2016-11-09 20:57:18]

A question and nit.

https://codereview.chromium.org/2491493004/diff/1/services/ui/ws/display.h
File services/ui/ws/display.h (right):

https://codereview.chromium.org/2491493004/diff/1/services/ui/ws/display.h#ne...
services/ui/ws/display.h:140: // Updates the size of display root ServerWindow
and WM ServerWindow(s) for
nit: "the display's root ServerWindow"? and "for the |new_size|", fix the other
mention of |size| to |new_size|.

https://codereview.chromium.org/2491493004/diff/1/services/ui/ws/display.h#ne...
services/ui/ws/display.h:142: void UpdateRootWindowSize(const gfx::Size&
new_size);
Would it make sense to keep this as OnViewportMetricsChanged, and just have the
impl use its pixel_size?

[kylechar, 2016-11-09 21:36:56]

https://codereview.chromium.org/2491493004/diff/1/services/ui/ws/display.h
File services/ui/ws/display.h (right):

https://codereview.chromium.org/2491493004/diff/1/services/ui/ws/display.h#ne...
services/ui/ws/display.h:140: // Updates the size of display root ServerWindow
and WM ServerWindow(s) for
On 2016/11/09 20:57:18, msw wrote:
> nit: "the display's root ServerWindow"? and "for the |new_size|", fix the
other
> mention of |size| to |new_size|.

Changed method otherwise.

https://codereview.chromium.org/2491493004/diff/1/services/ui/ws/display.h#ne...
services/ui/ws/display.h:142: void UpdateRootWindowSize(const gfx::Size&
new_size);
On 2016/11/09 20:57:18, msw wrote:
> Would it make sense to keep this as OnViewportMetricsChanged, and just have
the
> impl use its pixel_size?

Hmm, we're not using the rest of the values now.. but we definitely need them in
the future. Changed back.

[msw, 2016-11-09 22:22:12]

lgtm

[kylechar, 2016-11-09 22:42:15]

The CQ bit was checked by kylechar@chromium.org

[commit-bot: I haz the power, 2016-11-09 22:42:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-10 00:38:13]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-10 00:41:37]

Description was changed from

==========
Fix root ServerWindow size.

The root ServerWindow was changed to be created using physical pixel
size. When the root ServerWindow gets updated however it was still using
DIP size.

Use physical pixel size instead of DIP size. Also, don't need to check
if root_ exists, as it is initialized in the constructor, so should
always be there.

BUG=659673
==========

to

==========
Fix root ServerWindow size.

The root ServerWindow was changed to be created using physical pixel
size. When the root ServerWindow gets updated however it was still using
DIP size.

Use physical pixel size instead of DIP size. Also, don't need to check
if root_ exists, as it is initialized in the constructor, so should
always be there.

BUG=659673

Committed: https://crrev.com/47a013537bc0f554137b3ac2db6ce7762ff624f6
Cr-Commit-Position: refs/heads/master@{#431104}
==========

[commit-bot: I haz the power, 2016-11-10 00:41:41]

Patchset 2 (id:??) landed as
https://crrev.com/47a013537bc0f554137b3ac2db6ce7762ff624f6
Cr-Commit-Position: refs/heads/master@{#431104}