[Devil] Attempt to reboot via sysrq even if root fails.

[Devil] Attempt to reboot via sysrq even if root fails.

We are already in a failure mode, do everything we can to try and recover.

BUG=chromium:663748
Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/c93c05da306803130d46d1178fc1aa846d01aad7

[rnephew (Reviews Here), 2016-11-09 19:37:35]

rnephew@chromium.org changed reviewers:
+ jbudorick@chromium.org, mikecase@chromium.org

[jbudorick, 2016-11-09 19:39:19]

lgtm w/ nit

https://codereview.chromium.org/2491493003/diff/1/devil/devil/android/tools/d...
File devil/devil/android/tools/device_recovery.py (right):

https://codereview.chromium.org/2491493003/diff/1/devil/devil/android/tools/d...
devil/devil/android/tools/device_recovery.py:80: # We are already in a failure
mode, attempt to reboot regardless of what
nit: move this down into the finally block.

[rnephew (Reviews Here), 2016-11-09 19:45:09]

https://codereview.chromium.org/2491493003/diff/1/devil/devil/android/tools/d...
File devil/devil/android/tools/device_recovery.py (right):

https://codereview.chromium.org/2491493003/diff/1/devil/devil/android/tools/d...
devil/devil/android/tools/device_recovery.py:80: # We are already in a failure
mode, attempt to reboot regardless of what
On 2016/11/09 19:39:19, jbudorick wrote:
> nit: move this down into the finally block.

Done.

[rnephew (Reviews Here), 2016-11-09 19:45:11]

The CQ bit was checked by rnephew@chromium.org

[rnephew (Reviews Here), 2016-11-09 19:45:12]

The patchset sent to the CQ was uploaded after l-g-t-m from
jbudorick@chromium.org
Link to the patchset: https://codereview.chromium.org/2491493003/#ps20001
(title: "[Devil] Attempt to reboot via sysrq even if root fails.")

[commit-bot: I haz the power, 2016-11-09 19:45:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-09 20:05:07]

Description was changed from

==========
[Devil] Attempt to reboot via sysrq even if root fails.

We are already in a failure mode, do everything we can to try and recover.

BUG=chromium:663748
==========

to

==========
[Devil] Attempt to reboot via sysrq even if root fails.

We are already in a failure mode, do everything we can to try and recover.

BUG=chromium:663748

Committed:
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
==========

[commit-bot: I haz the power, 2016-11-09 20:05:08]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...