appengine/findit/waterfall/test/process_flake_swarming_task_result_pipeline_test.py - Issue 2491473002: [Findit] Implementing swarming task error detection

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/findit/waterfall/test/process_flake_swarming_task_result_pipeline_test.py

Issue 2491473002: [Findit] Implementing swarming task error detection (Closed)

Patch Set: Rebase Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « appengine/findit/waterfall/test/process_base_swarming_task_result_pipeline_test.py ('k') | appengine/findit/waterfall/test/process_swarming_task_result_pipeline_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: appengine/findit/waterfall/test/process_flake_swarming_task_result_pipeline_test.py

diff --git a/appengine/findit/waterfall/test/process_flake_swarming_task_result_pipeline_test.py b/appengine/findit/waterfall/test/process_flake_swarming_task_result_pipeline_test.py

index 86370bbca2e1b8e520edd23e08c0d321aa390599..48a1da092e6abd4da5ca11149d877c556629124b 100644

--- a/appengine/findit/waterfall/test/process_flake_swarming_task_result_pipeline_test.py

+++ b/appengine/findit/waterfall/test/process_flake_swarming_task_result_pipeline_test.py

@@ -18,7 +18,7 @@ from waterfall.test import wf_testcase

class ProcessFlakeSwarmingTaskResultPipelineTest(wf_testcase.WaterfallTestCase):

def _MockedGetSwarmingTaskResultById(self, task_id, _):

- return base_test._SWARMING_TASK_RESULTS[task_id]

+ return base_test._SWARMING_TASK_RESULTS[task_id], None

def setUp(self):

super(ProcessFlakeSwarmingTaskResultPipelineTest, self).setUp()

@@ -86,7 +86,7 @@ class ProcessFlakeSwarmingTaskResultPipelineTest(wf_testcase.WaterfallTestCase):

self.assertTrue(analysis.data_points[-1].pass_rate < 0)

def _MockedGetSwarmingTaskFailureLog(self, *_):

- return base_test._SAMPLE_FAILURE_LOG

+ return base_test._SAMPLE_FAILURE_LOG, None

def testProcessFlakeSwarmingTaskResultPipeline(self):

# End to end test.