appengine/findit/waterfall/test/trigger_flake_swarming_task_pipeline_test.py - Issue 2491473002: [Findit] Implementing swarming task error detection

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/findit/waterfall/test/trigger_flake_swarming_task_pipeline_test.py

Issue 2491473002: [Findit] Implementing swarming task error detection (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« appengine/findit/waterfall/swarming_util.py ('K') | « appengine/findit/waterfall/test/swarming_util_test.py ('k') | appengine/findit/waterfall/test/trigger_swarming_task_pipeline_test.py » ('j') | appengine/findit/waterfall/trigger_base_swarming_task_pipeline.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: appengine/findit/waterfall/test/trigger_flake_swarming_task_pipeline_test.py

diff --git a/appengine/findit/waterfall/test/trigger_flake_swarming_task_pipeline_test.py b/appengine/findit/waterfall/test/trigger_flake_swarming_task_pipeline_test.py

index aa897ca16d647d06e0f5fc7d70bb4878411ec025..0e529e1921eecde956b34f22865de5affba74d80 100644

--- a/appengine/findit/waterfall/test/trigger_flake_swarming_task_pipeline_test.py

+++ b/appengine/findit/waterfall/test/trigger_flake_swarming_task_pipeline_test.py

@@ -96,7 +96,7 @@ class TriggerFlakeSwarmingTaskPipelineTest(wf_testcase.WaterfallTestCase):

new_request_json = {}

def MockedTriggerSwarmingTask(new_request, *_):

new_request_json.update(new_request.Serialize())

- return 'new_task_id'

+ return 'new_task_id', None

self.mock(swarming_util, 'TriggerSwarmingTask', MockedTriggerSwarmingTask)

def MockedGetSwarmingTaskName(*_):