|
|
Description[debug] Disable debug events if JS execution is disallowed
We cannot generate debug events if JS execution is disallowed since
vital debugging logic is still implemented in JS. Return early from
Debug::OnException if that is the case.
BUG=chromium:662674
Committed: https://crrev.com/8f22fcec24abdece924190f413005387b8ced6fc
Cr-Commit-Position: refs/heads/master@{#40858}
Patch Set 1 #Patch Set 2 : [debug] Disable debug events if JS execution is disallowed #Patch Set 3 : Remove --expose-debug-as #Patch Set 4 : Address comments #
Messages
Total messages: 24 (18 generated)
The CQ bit was checked by jgruber@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
jgruber@chromium.org changed reviewers: + yangguo@chromium.org
Description was changed from ========== [debug] Disable debug events if JS execution is disallowed We cannot generate debug events if JS execution is disallowed since vital debugging logic is still implemented in JS. Return early from Debug::OnException if that is the case. BUG=chromium:622674 ========== to ========== [debug] Disable debug events if JS execution is disallowed We cannot generate debug events if JS execution is disallowed since vital debugging logic is still implemented in JS. Return early from Debug::OnException if that is the case. BUG=chromium:662674 ==========
The CQ bit was checked by jgruber@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by jgruber@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2016/11/09 09:24:17, jgruber wrote: You can probably make this test fail a bit sooner with the flag --stack-size=100 And you could make the assertion shorter like this: assertThrows(overthrow, RangeError) LGTM otherwise.
The CQ bit was checked by jgruber@chromium.org to run a CQ dry run
On 2016/11/09 11:24:36, Yang wrote: > On 2016/11/09 09:24:17, jgruber wrote: > > You can probably make this test fail a bit sooner with the flag --stack-size=100 > > And you could make the assertion shorter like this: > assertThrows(overthrow, RangeError) > > LGTM otherwise. Ty, all done.
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by jgruber@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from yangguo@chromium.org Link to the patchset: https://codereview.chromium.org/2491443002/#ps60001 (title: "Address comments")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [debug] Disable debug events if JS execution is disallowed We cannot generate debug events if JS execution is disallowed since vital debugging logic is still implemented in JS. Return early from Debug::OnException if that is the case. BUG=chromium:662674 ========== to ========== [debug] Disable debug events if JS execution is disallowed We cannot generate debug events if JS execution is disallowed since vital debugging logic is still implemented in JS. Return early from Debug::OnException if that is the case. BUG=chromium:662674 ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== [debug] Disable debug events if JS execution is disallowed We cannot generate debug events if JS execution is disallowed since vital debugging logic is still implemented in JS. Return early from Debug::OnException if that is the case. BUG=chromium:662674 ========== to ========== [debug] Disable debug events if JS execution is disallowed We cannot generate debug events if JS execution is disallowed since vital debugging logic is still implemented in JS. Return early from Debug::OnException if that is the case. BUG=chromium:662674 Committed: https://crrev.com/8f22fcec24abdece924190f413005387b8ced6fc Cr-Commit-Position: refs/heads/master@{#40858} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/8f22fcec24abdece924190f413005387b8ced6fc Cr-Commit-Position: refs/heads/master@{#40858} |