[debug] Disable debug events if JS execution is disallowed

[debug] Disable debug events if JS execution is disallowed

We cannot generate debug events if JS execution is disallowed since
vital debugging logic is still implemented in JS. Return early from
Debug::OnException if that is the case.

BUG=chromium:662674
Committed: https://crrev.com/8f22fcec24abdece924190f413005387b8ced6fc
Cr-Commit-Position: refs/heads/master@{#40858}

[jgruber, 2016-11-09 09:19:25]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-09 09:19:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jgruber, 2016-11-09 09:24:17]

jgruber@chromium.org changed reviewers:
+ yangguo@chromium.org

[jgruber, 2016-11-09 09:24:41]

Description was changed from

==========
[debug] Disable debug events if JS execution is disallowed

We cannot generate debug events if JS execution is disallowed since
vital debugging logic is still implemented in JS. Return early from
Debug::OnException if that is the case.

BUG=chromium:622674
==========

to

==========
[debug] Disable debug events if JS execution is disallowed

We cannot generate debug events if JS execution is disallowed since
vital debugging logic is still implemented in JS. Return early from
Debug::OnException if that is the case.

BUG=chromium:662674
==========

[jgruber, 2016-11-09 09:27:26]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-09 09:27:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jgruber, 2016-11-09 09:27:57]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-09 09:28:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-09 09:53:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-09 09:53:34]

Dry run: This issue passed the CQ dry run.

[Yang, 2016-11-09 11:24:36]

On 2016/11/09 09:24:17, jgruber wrote:

You can probably make this test fail a bit sooner with the flag --stack-size=100

And you could make the assertion shorter like this:
assertThrows(overthrow, RangeError)

LGTM otherwise.

[jgruber, 2016-11-09 11:57:13]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[jgruber, 2016-11-09 11:57:23]

On 2016/11/09 11:24:36, Yang wrote:
> On 2016/11/09 09:24:17, jgruber wrote:
> 
> You can probably make this test fail a bit sooner with the flag
--stack-size=100
> 
> And you could make the assertion shorter like this:
> assertThrows(overthrow, RangeError)
> 
> LGTM otherwise.

Ty, all done.

[commit-bot: I haz the power, 2016-11-09 11:57:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-09 12:23:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-09 12:23:12]

Dry run: This issue passed the CQ dry run.

[jgruber, 2016-11-09 12:28:01]

The CQ bit was checked by jgruber@chromium.org

[jgruber, 2016-11-09 12:28:01]

The patchset sent to the CQ was uploaded after l-g-t-m from yangguo@chromium.org
Link to the patchset: https://codereview.chromium.org/2491443002/#ps60001
(title: "Address comments")

[commit-bot: I haz the power, 2016-11-09 12:28:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-09 12:30:11]

Description was changed from

==========
[debug] Disable debug events if JS execution is disallowed

We cannot generate debug events if JS execution is disallowed since
vital debugging logic is still implemented in JS. Return early from
Debug::OnException if that is the case.

BUG=chromium:662674
==========

to

==========
[debug] Disable debug events if JS execution is disallowed

We cannot generate debug events if JS execution is disallowed since
vital debugging logic is still implemented in JS. Return early from
Debug::OnException if that is the case.

BUG=chromium:662674
==========

[commit-bot: I haz the power, 2016-11-09 12:30:12]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-11-17 22:27:22]

Description was changed from

==========
[debug] Disable debug events if JS execution is disallowed

We cannot generate debug events if JS execution is disallowed since
vital debugging logic is still implemented in JS. Return early from
Debug::OnException if that is the case.

BUG=chromium:662674
==========

to

==========
[debug] Disable debug events if JS execution is disallowed

We cannot generate debug events if JS execution is disallowed since
vital debugging logic is still implemented in JS. Return early from
Debug::OnException if that is the case.

BUG=chromium:662674

Committed: https://crrev.com/8f22fcec24abdece924190f413005387b8ced6fc
Cr-Commit-Position: refs/heads/master@{#40858}
==========

[commit-bot: I haz the power, 2016-11-17 22:27:23]

Patchset 4 (id:??) landed as
https://crrev.com/8f22fcec24abdece924190f413005387b8ced6fc
Cr-Commit-Position: refs/heads/master@{#40858}