Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 2491443002: [debug] Disable debug events if JS execution is disallowed (Closed)

Created:
4 years, 1 month ago by jgruber
Modified:
4 years, 1 month ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com, Dan Ehrenberg
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[debug] Disable debug events if JS execution is disallowed We cannot generate debug events if JS execution is disallowed since vital debugging logic is still implemented in JS. Return early from Debug::OnException if that is the case. BUG=chromium:662674 Committed: https://crrev.com/8f22fcec24abdece924190f413005387b8ced6fc Cr-Commit-Position: refs/heads/master@{#40858}

Patch Set 1 #

Patch Set 2 : [debug] Disable debug events if JS execution is disallowed #

Patch Set 3 : Remove --expose-debug-as #

Patch Set 4 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -0 lines) Patch
M src/debug/debug.cc View 1 chunk +5 lines, -0 lines 0 comments Download
A test/debugger/debug/regress/regress-662674.js View 1 2 3 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 24 (18 generated)
jgruber
4 years, 1 month ago (2016-11-09 09:24:17 UTC) #4
Yang
On 2016/11/09 09:24:17, jgruber wrote: You can probably make this test fail a bit sooner ...
4 years, 1 month ago (2016-11-09 11:24:36 UTC) #12
jgruber
On 2016/11/09 11:24:36, Yang wrote: > On 2016/11/09 09:24:17, jgruber wrote: > > You can ...
4 years, 1 month ago (2016-11-09 11:57:23 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2491443002/60001
4 years, 1 month ago (2016-11-09 12:28:11 UTC) #20
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 1 month ago (2016-11-09 12:30:12 UTC) #22
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:27:23 UTC) #24
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/8f22fcec24abdece924190f413005387b8ced6fc
Cr-Commit-Position: refs/heads/master@{#40858}

Powered by Google App Engine
This is Rietveld 408576698