Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2491403004:
Remove CallMsgFilter from MessagePumpWin (Closed)
DescriptionRemove CallMsgFilter from MessagePumpWin
kMessageFilterCode is defined locally in message_pump_win.cc.
CallMsgFilter is called with this parameter so that WH_SYSMSGFILTER
and WH_MSGFILTER hooks can look for them.
1) By construction, no hooks can look for kMessageFilterCode since
there are no hooks in message_pump_win.cc. No other components
can look for kMessageFilterCode since it is defined locally to
message_pump_win.cc
2) WH_SYSMSGFILTER and WH_MSGFILTER do not occur anywhere in the
Chromium codebase.
As a result, we do not need this call in our message pump anymore.
History:
Introduced for dragging a virtual file out of the browser.
https://chromium.googlesource.com/chromium/src/+/6aa4a1c041ca9bd2c3087c3c059a87193b1a82e1
chrome/browser/views/tab_contents/tab_contents_drag_win.cc
Moved To
* chrome/browser/ui/views/tab_contents/tab_contents_drag_win.cc [1]
* content/browser/tab_contents/web_contents_drag_win.cc [2]
* content/browser/web_contents/web_contents_drag_win.cc [3]
[1] https://chromium.googlesource.com/chromium/src/+/213dac2f0bff9162502fe325b6ebb85a255efcb2
[2] https://chromium.googlesource.com/chromium/src/+/95f072f9ce35f0ecd2cbf899de96fa9448aa1285
[3] https://chromium.googlesource.com/chromium/src/+/0c4e92e6434bb8936aca2e03fe8d44201cb51089
Deleted in
https://chromium.googlesource.com/chromium/src/+/2ceee8f17b6fa286d37f0e9190fed01e5f6a9eff
The associated hook code was not migrated to a different file in this
change.
The WH_MSGFILTER unit test for MessageLoopWin was removed in
https://chromium.googlesource.com/chromium/src/+/e73d0300622dbaf3af59863ed1b1370fa76cfdc7
BUG=660930
Committed: https://crrev.com/679a57d34267cd7e46e0a15da2dcdd71d76264a1
Cr-Commit-Position: refs/heads/master@{#431391}
Patch Set 1 #
Messages
Total messages: 22 (13 generated)
Description was changed from ========== Remove CallMsgFilter from MessagePumpWin kMessageFilterCode is only defined in message_pump_win.cc. CallMsgFilter is called with this parameter so that WH_SYSMSGFILTER and WH_MSGFILTER hooks can look for them. 1) By construction, no hooks can look for kMessageFilterCode since there are no hooks in MessagePumpWin. 2) WH_SYSMSGFILTER and WH_MSGFILTER do not occur anywhere in the Chromium codebase. As a result, we do not need this call in our message pump anymore. History: Introduced for dragging a virtual file out of the browser. https://chromium.googlesource.com/chromium/src/+/6aa4a1c041ca9bd2c3087c3c059a... chrome/browser/views/tab_contents/tab_contents_drag_win.cc Moves To * chrome/browser/ui/views/tab_contents/tab_contents_drag_win.cc [1] * content/browser/tab_contents/web_contents_drag_win.cc [2] * content/browser/web_contents/web_contents_drag_win.cc [3] [1] https://chromium.googlesource.com/chromium/src/+/213dac2f0bff9162502fe325b6eb... [2] https://chromium.googlesource.com/chromium/src/+/95f072f9ce35f0ecd2cbf899de96... [3] https://chromium.googlesource.com/chromium/src/+/0c4e92e6434bb8936aca2e03fe8d... Deleted in https://chromium.googlesource.com/chromium/src/+/2ceee8f17b6fa286d37f0e9190fe... The associated hook code was not migrated to a different file in this change. BUG=660930 ========== to ========== Remove CallMsgFilter from MessagePumpWin kMessageFilterCode is only defined in message_pump_win.cc. CallMsgFilter is called with this parameter so that WH_SYSMSGFILTER and WH_MSGFILTER hooks can look for them. 1) By construction, no hooks can look for kMessageFilterCode since there are no hooks in MessagePumpWin. 2) WH_SYSMSGFILTER and WH_MSGFILTER do not occur anywhere in the Chromium codebase. As a result, we do not need this call in our message pump anymore. History: Introduced for dragging a virtual file out of the browser. https://chromium.googlesource.com/chromium/src/+/6aa4a1c041ca9bd2c3087c3c059a... chrome/browser/views/tab_contents/tab_contents_drag_win.cc Moves To * chrome/browser/ui/views/tab_contents/tab_contents_drag_win.cc [1] * content/browser/tab_contents/web_contents_drag_win.cc [2] * content/browser/web_contents/web_contents_drag_win.cc [3] [1] https://chromium.googlesource.com/chromium/src/+/213dac2f0bff9162502fe325b6eb... [2] https://chromium.googlesource.com/chromium/src/+/95f072f9ce35f0ecd2cbf899de96... [3] https://chromium.googlesource.com/chromium/src/+/0c4e92e6434bb8936aca2e03fe8d... Deleted in https://chromium.googlesource.com/chromium/src/+/2ceee8f17b6fa286d37f0e9190fe... The associated hook code was not migrated to a different file in this change. The Hook unit test for MessageLoopWin was removed in https://chromium.googlesource.com/chromium/src/+/e73d0300622dbaf3af59863ed1b1... BUG=660930 ==========
Description was changed from ========== Remove CallMsgFilter from MessagePumpWin kMessageFilterCode is only defined in message_pump_win.cc. CallMsgFilter is called with this parameter so that WH_SYSMSGFILTER and WH_MSGFILTER hooks can look for them. 1) By construction, no hooks can look for kMessageFilterCode since there are no hooks in MessagePumpWin. 2) WH_SYSMSGFILTER and WH_MSGFILTER do not occur anywhere in the Chromium codebase. As a result, we do not need this call in our message pump anymore. History: Introduced for dragging a virtual file out of the browser. https://chromium.googlesource.com/chromium/src/+/6aa4a1c041ca9bd2c3087c3c059a... chrome/browser/views/tab_contents/tab_contents_drag_win.cc Moves To * chrome/browser/ui/views/tab_contents/tab_contents_drag_win.cc [1] * content/browser/tab_contents/web_contents_drag_win.cc [2] * content/browser/web_contents/web_contents_drag_win.cc [3] [1] https://chromium.googlesource.com/chromium/src/+/213dac2f0bff9162502fe325b6eb... [2] https://chromium.googlesource.com/chromium/src/+/95f072f9ce35f0ecd2cbf899de96... [3] https://chromium.googlesource.com/chromium/src/+/0c4e92e6434bb8936aca2e03fe8d... Deleted in https://chromium.googlesource.com/chromium/src/+/2ceee8f17b6fa286d37f0e9190fe... The associated hook code was not migrated to a different file in this change. The Hook unit test for MessageLoopWin was removed in https://chromium.googlesource.com/chromium/src/+/e73d0300622dbaf3af59863ed1b1... BUG=660930 ========== to ========== Remove CallMsgFilter from MessagePumpWin kMessageFilterCode is only defined in message_pump_win.cc. CallMsgFilter is called with this parameter so that WH_SYSMSGFILTER and WH_MSGFILTER hooks can look for them. 1) By construction, no hooks can look for kMessageFilterCode since there are no hooks in MessagePumpWin. 2) WH_SYSMSGFILTER and WH_MSGFILTER do not occur anywhere in the Chromium codebase. As a result, we do not need this call in our message pump anymore. History: Introduced for dragging a virtual file out of the browser. https://chromium.googlesource.com/chromium/src/+/6aa4a1c041ca9bd2c3087c3c059a... chrome/browser/views/tab_contents/tab_contents_drag_win.cc Moves To * chrome/browser/ui/views/tab_contents/tab_contents_drag_win.cc [1] * content/browser/tab_contents/web_contents_drag_win.cc [2] * content/browser/web_contents/web_contents_drag_win.cc [3] [1] https://chromium.googlesource.com/chromium/src/+/213dac2f0bff9162502fe325b6eb... [2] https://chromium.googlesource.com/chromium/src/+/95f072f9ce35f0ecd2cbf899de96... [3] https://chromium.googlesource.com/chromium/src/+/0c4e92e6434bb8936aca2e03fe8d... Deleted in https://chromium.googlesource.com/chromium/src/+/2ceee8f17b6fa286d37f0e9190fe... The associated hook code was not migrated to a different file in this change. The WH_MSGFILTER unit test for MessageLoopWin was removed in https://chromium.googlesource.com/chromium/src/+/e73d0300622dbaf3af59863ed1b1... BUG=660930 ==========
The CQ bit was checked by robliao@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Remove CallMsgFilter from MessagePumpWin kMessageFilterCode is only defined in message_pump_win.cc. CallMsgFilter is called with this parameter so that WH_SYSMSGFILTER and WH_MSGFILTER hooks can look for them. 1) By construction, no hooks can look for kMessageFilterCode since there are no hooks in MessagePumpWin. 2) WH_SYSMSGFILTER and WH_MSGFILTER do not occur anywhere in the Chromium codebase. As a result, we do not need this call in our message pump anymore. History: Introduced for dragging a virtual file out of the browser. https://chromium.googlesource.com/chromium/src/+/6aa4a1c041ca9bd2c3087c3c059a... chrome/browser/views/tab_contents/tab_contents_drag_win.cc Moves To * chrome/browser/ui/views/tab_contents/tab_contents_drag_win.cc [1] * content/browser/tab_contents/web_contents_drag_win.cc [2] * content/browser/web_contents/web_contents_drag_win.cc [3] [1] https://chromium.googlesource.com/chromium/src/+/213dac2f0bff9162502fe325b6eb... [2] https://chromium.googlesource.com/chromium/src/+/95f072f9ce35f0ecd2cbf899de96... [3] https://chromium.googlesource.com/chromium/src/+/0c4e92e6434bb8936aca2e03fe8d... Deleted in https://chromium.googlesource.com/chromium/src/+/2ceee8f17b6fa286d37f0e9190fe... The associated hook code was not migrated to a different file in this change. The WH_MSGFILTER unit test for MessageLoopWin was removed in https://chromium.googlesource.com/chromium/src/+/e73d0300622dbaf3af59863ed1b1... BUG=660930 ========== to ========== Remove CallMsgFilter from MessagePumpWin kMessageFilterCode is defined locally in message_pump_win.cc. CallMsgFilter is called with this parameter so that WH_SYSMSGFILTER and WH_MSGFILTER hooks can look for them. 1) By construction, no hooks can look for kMessageFilterCode since there are no hooks in message_pump_win.cc. No other components can look for kMessageFilterCode since it is defined locally to message_pump_win.cc 2) WH_SYSMSGFILTER and WH_MSGFILTER do not occur anywhere in the Chromium codebase. As a result, we do not need this call in our message pump anymore. History: Introduced for dragging a virtual file out of the browser. https://chromium.googlesource.com/chromium/src/+/6aa4a1c041ca9bd2c3087c3c059a... chrome/browser/views/tab_contents/tab_contents_drag_win.cc Moves To * chrome/browser/ui/views/tab_contents/tab_contents_drag_win.cc [1] * content/browser/tab_contents/web_contents_drag_win.cc [2] * content/browser/web_contents/web_contents_drag_win.cc [3] [1] https://chromium.googlesource.com/chromium/src/+/213dac2f0bff9162502fe325b6eb... [2] https://chromium.googlesource.com/chromium/src/+/95f072f9ce35f0ecd2cbf899de96... [3] https://chromium.googlesource.com/chromium/src/+/0c4e92e6434bb8936aca2e03fe8d... Deleted in https://chromium.googlesource.com/chromium/src/+/2ceee8f17b6fa286d37f0e9190fe... The associated hook code was not migrated to a different file in this change. The WH_MSGFILTER unit test for MessageLoopWin was removed in https://chromium.googlesource.com/chromium/src/+/e73d0300622dbaf3af59863ed1b1... BUG=660930 ==========
robliao@chromium.org changed reviewers: + scottmg@chromium.org
scottmg: Please review this Windows change for Chrome. Thanks!
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2016/11/10 19:17:12, robliao wrote: > scottmg: Please review this Windows change for Chrome. > > Thanks! The delete doesn't look like it was on purpose? Is this possibly why we can't drag things out, e.g. https://bugs.chromium.org/p/chromium/issues/detail?id=464474 ?
On 2016/11/10 20:05:10, scottmg wrote: > On 2016/11/10 19:17:12, robliao wrote: > > scottmg: Please review this Windows change for Chrome. > > > > Thanks! > > The delete doesn't look like it was on purpose? Is this possibly why we can't > drag things out, e.g. > https://bugs.chromium.org/p/chromium/issues/detail?id=464474 ? <img> tags seem to work fine for me, suggesting that the equivalent functionality needs to be implemented for <video>
OK, LGTM
robliao@chromium.org changed reviewers: + dcheng@chromium.org
dcheng@chromium.org: Please review this change. Thanks!
Description was changed from ========== Remove CallMsgFilter from MessagePumpWin kMessageFilterCode is defined locally in message_pump_win.cc. CallMsgFilter is called with this parameter so that WH_SYSMSGFILTER and WH_MSGFILTER hooks can look for them. 1) By construction, no hooks can look for kMessageFilterCode since there are no hooks in message_pump_win.cc. No other components can look for kMessageFilterCode since it is defined locally to message_pump_win.cc 2) WH_SYSMSGFILTER and WH_MSGFILTER do not occur anywhere in the Chromium codebase. As a result, we do not need this call in our message pump anymore. History: Introduced for dragging a virtual file out of the browser. https://chromium.googlesource.com/chromium/src/+/6aa4a1c041ca9bd2c3087c3c059a... chrome/browser/views/tab_contents/tab_contents_drag_win.cc Moves To * chrome/browser/ui/views/tab_contents/tab_contents_drag_win.cc [1] * content/browser/tab_contents/web_contents_drag_win.cc [2] * content/browser/web_contents/web_contents_drag_win.cc [3] [1] https://chromium.googlesource.com/chromium/src/+/213dac2f0bff9162502fe325b6eb... [2] https://chromium.googlesource.com/chromium/src/+/95f072f9ce35f0ecd2cbf899de96... [3] https://chromium.googlesource.com/chromium/src/+/0c4e92e6434bb8936aca2e03fe8d... Deleted in https://chromium.googlesource.com/chromium/src/+/2ceee8f17b6fa286d37f0e9190fe... The associated hook code was not migrated to a different file in this change. The WH_MSGFILTER unit test for MessageLoopWin was removed in https://chromium.googlesource.com/chromium/src/+/e73d0300622dbaf3af59863ed1b1... BUG=660930 ========== to ========== Remove CallMsgFilter from MessagePumpWin kMessageFilterCode is defined locally in message_pump_win.cc. CallMsgFilter is called with this parameter so that WH_SYSMSGFILTER and WH_MSGFILTER hooks can look for them. 1) By construction, no hooks can look for kMessageFilterCode since there are no hooks in message_pump_win.cc. No other components can look for kMessageFilterCode since it is defined locally to message_pump_win.cc 2) WH_SYSMSGFILTER and WH_MSGFILTER do not occur anywhere in the Chromium codebase. As a result, we do not need this call in our message pump anymore. History: Introduced for dragging a virtual file out of the browser. https://chromium.googlesource.com/chromium/src/+/6aa4a1c041ca9bd2c3087c3c059a... chrome/browser/views/tab_contents/tab_contents_drag_win.cc Moved To * chrome/browser/ui/views/tab_contents/tab_contents_drag_win.cc [1] * content/browser/tab_contents/web_contents_drag_win.cc [2] * content/browser/web_contents/web_contents_drag_win.cc [3] [1] https://chromium.googlesource.com/chromium/src/+/213dac2f0bff9162502fe325b6eb... [2] https://chromium.googlesource.com/chromium/src/+/95f072f9ce35f0ecd2cbf899de96... [3] https://chromium.googlesource.com/chromium/src/+/0c4e92e6434bb8936aca2e03fe8d... Deleted in https://chromium.googlesource.com/chromium/src/+/2ceee8f17b6fa286d37f0e9190fe... The associated hook code was not migrated to a different file in this change. The WH_MSGFILTER unit test for MessageLoopWin was removed in https://chromium.googlesource.com/chromium/src/+/e73d0300622dbaf3af59863ed1b1... BUG=660930 ==========
rs lgtm, scottmg knows this way better than i do =)
The CQ bit was checked by robliao@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Remove CallMsgFilter from MessagePumpWin kMessageFilterCode is defined locally in message_pump_win.cc. CallMsgFilter is called with this parameter so that WH_SYSMSGFILTER and WH_MSGFILTER hooks can look for them. 1) By construction, no hooks can look for kMessageFilterCode since there are no hooks in message_pump_win.cc. No other components can look for kMessageFilterCode since it is defined locally to message_pump_win.cc 2) WH_SYSMSGFILTER and WH_MSGFILTER do not occur anywhere in the Chromium codebase. As a result, we do not need this call in our message pump anymore. History: Introduced for dragging a virtual file out of the browser. https://chromium.googlesource.com/chromium/src/+/6aa4a1c041ca9bd2c3087c3c059a... chrome/browser/views/tab_contents/tab_contents_drag_win.cc Moved To * chrome/browser/ui/views/tab_contents/tab_contents_drag_win.cc [1] * content/browser/tab_contents/web_contents_drag_win.cc [2] * content/browser/web_contents/web_contents_drag_win.cc [3] [1] https://chromium.googlesource.com/chromium/src/+/213dac2f0bff9162502fe325b6eb... [2] https://chromium.googlesource.com/chromium/src/+/95f072f9ce35f0ecd2cbf899de96... [3] https://chromium.googlesource.com/chromium/src/+/0c4e92e6434bb8936aca2e03fe8d... Deleted in https://chromium.googlesource.com/chromium/src/+/2ceee8f17b6fa286d37f0e9190fe... The associated hook code was not migrated to a different file in this change. The WH_MSGFILTER unit test for MessageLoopWin was removed in https://chromium.googlesource.com/chromium/src/+/e73d0300622dbaf3af59863ed1b1... BUG=660930 ========== to ========== Remove CallMsgFilter from MessagePumpWin kMessageFilterCode is defined locally in message_pump_win.cc. CallMsgFilter is called with this parameter so that WH_SYSMSGFILTER and WH_MSGFILTER hooks can look for them. 1) By construction, no hooks can look for kMessageFilterCode since there are no hooks in message_pump_win.cc. No other components can look for kMessageFilterCode since it is defined locally to message_pump_win.cc 2) WH_SYSMSGFILTER and WH_MSGFILTER do not occur anywhere in the Chromium codebase. As a result, we do not need this call in our message pump anymore. History: Introduced for dragging a virtual file out of the browser. https://chromium.googlesource.com/chromium/src/+/6aa4a1c041ca9bd2c3087c3c059a... chrome/browser/views/tab_contents/tab_contents_drag_win.cc Moved To * chrome/browser/ui/views/tab_contents/tab_contents_drag_win.cc [1] * content/browser/tab_contents/web_contents_drag_win.cc [2] * content/browser/web_contents/web_contents_drag_win.cc [3] [1] https://chromium.googlesource.com/chromium/src/+/213dac2f0bff9162502fe325b6eb... [2] https://chromium.googlesource.com/chromium/src/+/95f072f9ce35f0ecd2cbf899de96... [3] https://chromium.googlesource.com/chromium/src/+/0c4e92e6434bb8936aca2e03fe8d... Deleted in https://chromium.googlesource.com/chromium/src/+/2ceee8f17b6fa286d37f0e9190fe... The associated hook code was not migrated to a different file in this change. The WH_MSGFILTER unit test for MessageLoopWin was removed in https://chromium.googlesource.com/chromium/src/+/e73d0300622dbaf3af59863ed1b1... BUG=660930 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Remove CallMsgFilter from MessagePumpWin kMessageFilterCode is defined locally in message_pump_win.cc. CallMsgFilter is called with this parameter so that WH_SYSMSGFILTER and WH_MSGFILTER hooks can look for them. 1) By construction, no hooks can look for kMessageFilterCode since there are no hooks in message_pump_win.cc. No other components can look for kMessageFilterCode since it is defined locally to message_pump_win.cc 2) WH_SYSMSGFILTER and WH_MSGFILTER do not occur anywhere in the Chromium codebase. As a result, we do not need this call in our message pump anymore. History: Introduced for dragging a virtual file out of the browser. https://chromium.googlesource.com/chromium/src/+/6aa4a1c041ca9bd2c3087c3c059a... chrome/browser/views/tab_contents/tab_contents_drag_win.cc Moved To * chrome/browser/ui/views/tab_contents/tab_contents_drag_win.cc [1] * content/browser/tab_contents/web_contents_drag_win.cc [2] * content/browser/web_contents/web_contents_drag_win.cc [3] [1] https://chromium.googlesource.com/chromium/src/+/213dac2f0bff9162502fe325b6eb... [2] https://chromium.googlesource.com/chromium/src/+/95f072f9ce35f0ecd2cbf899de96... [3] https://chromium.googlesource.com/chromium/src/+/0c4e92e6434bb8936aca2e03fe8d... Deleted in https://chromium.googlesource.com/chromium/src/+/2ceee8f17b6fa286d37f0e9190fe... The associated hook code was not migrated to a different file in this change. The WH_MSGFILTER unit test for MessageLoopWin was removed in https://chromium.googlesource.com/chromium/src/+/e73d0300622dbaf3af59863ed1b1... BUG=660930 ========== to ========== Remove CallMsgFilter from MessagePumpWin kMessageFilterCode is defined locally in message_pump_win.cc. CallMsgFilter is called with this parameter so that WH_SYSMSGFILTER and WH_MSGFILTER hooks can look for them. 1) By construction, no hooks can look for kMessageFilterCode since there are no hooks in message_pump_win.cc. No other components can look for kMessageFilterCode since it is defined locally to message_pump_win.cc 2) WH_SYSMSGFILTER and WH_MSGFILTER do not occur anywhere in the Chromium codebase. As a result, we do not need this call in our message pump anymore. History: Introduced for dragging a virtual file out of the browser. https://chromium.googlesource.com/chromium/src/+/6aa4a1c041ca9bd2c3087c3c059a... chrome/browser/views/tab_contents/tab_contents_drag_win.cc Moved To * chrome/browser/ui/views/tab_contents/tab_contents_drag_win.cc [1] * content/browser/tab_contents/web_contents_drag_win.cc [2] * content/browser/web_contents/web_contents_drag_win.cc [3] [1] https://chromium.googlesource.com/chromium/src/+/213dac2f0bff9162502fe325b6eb... [2] https://chromium.googlesource.com/chromium/src/+/95f072f9ce35f0ecd2cbf899de96... [3] https://chromium.googlesource.com/chromium/src/+/0c4e92e6434bb8936aca2e03fe8d... Deleted in https://chromium.googlesource.com/chromium/src/+/2ceee8f17b6fa286d37f0e9190fe... The associated hook code was not migrated to a different file in this change. The WH_MSGFILTER unit test for MessageLoopWin was removed in https://chromium.googlesource.com/chromium/src/+/e73d0300622dbaf3af59863ed1b1... BUG=660930 Committed: https://crrev.com/679a57d34267cd7e46e0a15da2dcdd71d76264a1 Cr-Commit-Position: refs/heads/master@{#431391} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/679a57d34267cd7e46e0a15da2dcdd71d76264a1 Cr-Commit-Position: refs/heads/master@{#431391} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
