chromeos: Move SystemTrayDelegate::RequestShutdown to WmShell

chromeos: Move SystemTrayDelegate::RequestShutdown to WmShell

For mustash the chrome browser process cannot call directly into ash. The
implementation of this method in chrome's SystemTrayDelegateChromeos just
turns around and calls into ash::LockStateController.

Moving the method allows ash to process these requests internally. The mus
implementation is still NOTIMPLEMENTED because we don't have mus support
for LockStateController and its animations.

After removing another unused method this results in SystemTrayDelegateChromeos
having no ash::Shell references. (It still uses ash::WmShell, though.)

This is part 1 of moving shutdown handling out of chrome into ash.

BUG=644348, 647412
TEST=Shutdown from system tray still works in classic ash

Committed: https://crrev.com/04570b6023aeada35ead88f6488618be307793d1
Cr-Commit-Position: refs/heads/master@{#431323}

[James Cook, 2016-11-10 18:59:08]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-10 18:59:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[James Cook, 2016-11-10 19:00:22]

jamescook@chromium.org changed reviewers:
+ derat@chromium.org

[James Cook, 2016-11-10 19:00:22]

Dan, please take a look. This is part of my ongoing quest to break direct ash /
chrome dependencies in the system tray.

[Daniel Erat, 2016-11-10 19:24:53]

lgtm

https://codereview.chromium.org/2491403003/diff/1/ash/common/wm_shell.h
File ash/common/wm_shell.h (right):

https://codereview.chromium.org/2491403003/diff/1/ash/common/wm_shell.h#newco...
ash/common/wm_shell.h:403: // TODO(mash): Remove this method and call
LockStateController directly when
just double-checked that there don't appear to be any committers with this
username :-)

as an aside, i wouldn't mind if you felt like giving LockStateController a
better name while you're working on it. it deals with both locking and shutting
down. the thing that does animations for it is called SessionStateAnimator, but
SessionStateController may be confusing since we also have SessionStateDelegate
and SessionStateObserver in ash/common/session.

[James Cook, 2016-11-10 19:31:03]

The CQ bit was unchecked by jamescook@chromium.org

[James Cook, 2016-11-10 19:31:06]

The CQ bit was checked by jamescook@chromium.org

[commit-bot: I haz the power, 2016-11-10 19:31:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-10 19:52:35]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-10 20:10:44]

Description was changed from

==========
chromeos: Move SystemTrayDelegate::RequestShutdown to WmShell

For mustash the chrome browser process cannot call directly into ash. The
implementation of this method in chrome's SystemTrayDelegateChromeos just
turns around and calls into ash::LockStateController.

Moving the method allows ash to process these requests internally. The mus
implementation is still NOTIMPLEMENTED because we don't have mus support
for LockStateController and its animations.

After removing another unused method this results in SystemTrayDelegateChromeos
having no ash::Shell references. (It still uses ash::WmShell, though.)

This is part 1 of moving shutdown handling out of chrome into ash.

BUG=644348, 647412
TEST=Shutdown from system tray still works in classic ash
==========

to

==========
chromeos: Move SystemTrayDelegate::RequestShutdown to WmShell

For mustash the chrome browser process cannot call directly into ash. The
implementation of this method in chrome's SystemTrayDelegateChromeos just
turns around and calls into ash::LockStateController.

Moving the method allows ash to process these requests internally. The mus
implementation is still NOTIMPLEMENTED because we don't have mus support
for LockStateController and its animations.

After removing another unused method this results in SystemTrayDelegateChromeos
having no ash::Shell references. (It still uses ash::WmShell, though.)

This is part 1 of moving shutdown handling out of chrome into ash.

BUG=644348, 647412
TEST=Shutdown from system tray still works in classic ash

Committed: https://crrev.com/04570b6023aeada35ead88f6488618be307793d1
Cr-Commit-Position: refs/heads/master@{#431323}
==========

[commit-bot: I haz the power, 2016-11-10 20:10:45]

Patchset 1 (id:??) landed as
https://crrev.com/04570b6023aeada35ead88f6488618be307793d1
Cr-Commit-Position: refs/heads/master@{#431323}