Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Unified Diff: ios/chrome/browser/reading_list/reading_list_entry.h

Issue 2491383002: Use Distilled path instead of DistilledURL. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/reading_list/reading_list_entry.h
diff --git a/ios/chrome/browser/reading_list/reading_list_entry.h b/ios/chrome/browser/reading_list/reading_list_entry.h
index 3ed4903e8e6226a817acd367e997cb5fc1a8fa0b..40e4f9bef2b98cba93844e24f4c4c5912adf3437 100644
--- a/ios/chrome/browser/reading_list/reading_list_entry.h
+++ b/ios/chrome/browser/reading_list/reading_list_entry.h
@@ -7,6 +7,7 @@
#include <string>
+#include "base/files/file_path.h"
#include "base/macros.h"
#include "net/base/backoff_entry.h"
#include "url/gurl.h"
@@ -39,7 +40,9 @@ class ReadingListEntry {
DistillationState DistilledState() const;
// The local file URL for the distilled version of the page. This should only
jif-google 2016/11/10 15:48:24 s/file URL/filepath/
Olivier 2016/11/10 16:49:10 Done.
// be called if the state is "PROCESSED".
- const GURL& DistilledURL() const;
+ const base::FilePath& DistilledPath() const;
+ // The URL to the distilled file.
+ const GURL DistilledURL() const;
gambard 2016/11/10 16:07:08 Are we still using this?
Olivier 2016/11/10 16:49:10 Yes, to load the page. The meaninq is different. I
// The time before the next try. This is automatically increased when the
// state is set to WILL_RETRY or ERROR from a non-error state.
base::TimeDelta TimeUntilNextTry() const;
@@ -55,14 +58,14 @@ class ReadingListEntry {
void SetTitle(const std::string& title);
// Sets the distilled URL and switch the state to PROCESSED and reset the time
// until the next try.
- void SetDistilledURL(const GURL& url);
+ void SetDistilledPath(const base::FilePath& url);
jif-google 2016/11/10 15:48:24 s/url/path/ Also, the comment needs to be updated
Olivier 2016/11/10 16:49:10 Done.
// Sets the state to one of PROCESSING, WILL_RETRY or ERROR.
void SetDistilledState(DistillationState distilled_state);
private:
GURL url_;
std::string title_;
- GURL distilled_url_;
+ base::FilePath distilled_path_;
DistillationState distilled_state_;
std::unique_ptr<net::BackoffEntry> backoff_;
int failed_download_counter_;

Powered by Google App Engine
This is Rietveld 408576698