[Android] Fix instrumentation test filtering for parameterized tests.

[Android] Fix instrumentation test filtering for parameterized tests.

BUG=664631
Committed: https://crrev.com/eda94f187790e1df877aaa4091f4c1810bcee84e
Cr-Commit-Position: refs/heads/master@{#431958}

[jbudorick, 2016-11-12 01:11:18]

jbudorick@chromium.org changed reviewers:
+ katthomas@chromium.org, mikecase@chromium.org

[mikecase (-- gone --), 2016-11-12 01:55:09]

https://codereview.chromium.org/2491373005/diff/1/build/android/pylib/instrum...
File build/android/pylib/instrumentation/instrumentation_test_instance.py
(right):

https://codereview.chromium.org/2491373005/diff/1/build/android/pylib/instrum...
build/android/pylib/instrumentation/instrumentation_test_instance.py:54: r'
with(?:out)? \{[^\}]*\}')
so, I could easily be wrong, but with this work on tests with both positive and
negative flags

mTestClass#testA with {foo} without {bar}

which I think can happen

https://codereview.chromium.org/2491373005/diff/1/build/android/pylib/instrum...
build/android/pylib/instrumentation/instrumentation_test_instance.py:229:
unqualified_class_test = {
unqualified_class_test is just like package-name-less test name right?

maybe change name to class_test_name_without_package. just kidding.

https://codereview.chromium.org/2491373005/diff/1/build/android/pylib/instrum...
build/android/pylib/instrumentation/instrumentation_test_instance.py:237: ]
I like this solution.  :D

[jbudorick, 2016-11-14 16:26:32]

https://codereview.chromium.org/2491373005/diff/1/build/android/pylib/instrum...
File build/android/pylib/instrumentation/instrumentation_test_instance.py
(right):

https://codereview.chromium.org/2491373005/diff/1/build/android/pylib/instrum...
build/android/pylib/instrumentation/instrumentation_test_instance.py:54: r'
with(?:out)? \{[^\}]*\}')
On 2016/11/12 01:55:08, mikecase wrote:
> so, I could easily be wrong, but with this work on tests with both positive
and
> negative flags
> 
> mTestClass#testA with {foo} without {bar}
> 
> which I think can happen

Yes, it should: https://docs.python.org/2/library/re.html#re.sub

https://codereview.chromium.org/2491373005/diff/1/build/android/pylib/instrum...
build/android/pylib/instrumentation/instrumentation_test_instance.py:229:
unqualified_class_test = {
On 2016/11/12 01:55:09, mikecase wrote:
> unqualified_class_test is just like package-name-less test name right?
> 
> maybe change name to class_test_name_without_package. just kidding.

Acknowledged.

https://codereview.chromium.org/2491373005/diff/1/build/android/pylib/instrum...
build/android/pylib/instrumentation/instrumentation_test_instance.py:237: ]
On 2016/11/12 01:55:09, mikecase wrote:
> I like this solution.  :D

Yeah, it's a bit more readable this way.

[katthomas, 2016-11-14 18:36:56]

katthomas@google.com changed reviewers:
+ katthomas@google.com

[katthomas, 2016-11-14 18:36:56]

lgtm

LGTM

[jbudorick, 2016-11-14 19:02:44]

The CQ bit was checked by jbudorick@chromium.org

[commit-bot: I haz the power, 2016-11-14 19:04:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-14 23:19:15]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-14 23:33:31]

Description was changed from

==========
[Android] Fix instrumentation test filtering for parameterized tests.

BUG=664631
==========

to

==========
[Android] Fix instrumentation test filtering for parameterized tests.

BUG=664631

Committed: https://crrev.com/eda94f187790e1df877aaa4091f4c1810bcee84e
Cr-Commit-Position: refs/heads/master@{#431958}
==========

[commit-bot: I haz the power, 2016-11-14 23:33:32]

Patchset 1 (id:??) landed as
https://crrev.com/eda94f187790e1df877aaa4091f4c1810bcee84e
Cr-Commit-Position: refs/heads/master@{#431958}