Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2491373003: Fix -Wshorten-64-to-32 errors on clang ARM64 (Closed)

Created:
4 years, 1 month ago by ynovikov
Modified:
4 years, 1 month ago
Reviewers:
rmcilroy
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix -Wshorten-64-to-32 errors on clang ARM64 Committed: https://crrev.com/3b49b45756f3ec1cadb2428fa2dea3859c0cb678 Cr-Commit-Position: refs/heads/master@{#40940}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M src/base/cpu.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
ynovikov
4 years, 1 month ago (2016-11-10 22:12:26 UTC) #2
rmcilroy
lgtm
4 years, 1 month ago (2016-11-11 11:37:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2491373003/1
4 years, 1 month ago (2016-11-11 19:52:51 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-11 20:19:31 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:31:23 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3b49b45756f3ec1cadb2428fa2dea3859c0cb678
Cr-Commit-Position: refs/heads/master@{#40940}

Powered by Google App Engine
This is Rietveld 408576698