Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Issue 2491363003: Make FileReader.abort() (synchronously) follow the spec. (Closed)

Created:
4 years, 1 month ago by sof
Modified:
4 years, 1 month ago
Reviewers:
jsbell, nhiroki
CC:
chromium-reviews, blink-reviews-w3ctests_chromium.org, tzik, tfarina, nhiroki, blink-reviews, kinuko+fileapi
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make FileReader.abort() (synchronously) follow the spec. It is problematic to cancel a ThreadableLoader (by way of FileReaderLoader) while it is on the stack, which is one of the steps involved when abort()ing a reader (as part of the "terminate" step.) To avoid such potential trouble, the loader termination is done asynchronously. However, there's no good reason to delay performing the other (user visible) abort() steps, so arrange for that to happen and align with the spec & others. R=jsbell BUG=288349 Committed: https://crrev.com/4557e0a6d697821badf2e8adb95d356a7cd85e62 Cr-Commit-Position: refs/heads/master@{#431639}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -27 lines) Patch
D third_party/WebKit/LayoutTests/imported/wpt/FileAPI/fileReader-expected.txt View 1 chunk +0 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/fileapi/FileReader.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/fileapi/FileReader.cpp View 4 chunks +13 lines, -18 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
sof
please take a look.
4 years, 1 month ago (2016-11-11 10:19:33 UTC) #4
jsbell
lgtm
4 years, 1 month ago (2016-11-11 16:56:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2491363003/1
4 years, 1 month ago (2016-11-11 20:44:47 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-11 20:51:51 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-11-11 21:00:47 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4557e0a6d697821badf2e8adb95d356a7cd85e62
Cr-Commit-Position: refs/heads/master@{#431639}

Powered by Google App Engine
This is Rietveld 408576698