Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 2491353002: Add CORE_EXPORT to blink::isFeatureEnabledInFrame for Feature Policy (Closed)

Created:
4 years, 1 month ago by iclelland
Modified:
4 years, 1 month ago
Reviewers:
Mike West
CC:
blink-reviews, blink-reviews-bindings_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add CORE_EXPORT to blink::isFeatureEnabledInFrame for Feature Policy BUG=623682 Committed: https://crrev.com/223219ddca24df5f57dfb8c7e286690ad8800d16 Cr-Commit-Position: refs/heads/master@{#431312}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M third_party/WebKit/Source/bindings/core/v8/ConditionalFeatures.h View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
iclelland
+r mkwst, can you approve this? This API was mistakenly left out of core exports. ...
4 years, 1 month ago (2016-11-10 14:46:48 UTC) #2
Mike West
lgtm
4 years, 1 month ago (2016-11-10 19:10:45 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2491353002/1
4 years, 1 month ago (2016-11-10 19:11:15 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-10 19:15:57 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-10 19:40:25 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/223219ddca24df5f57dfb8c7e286690ad8800d16
Cr-Commit-Position: refs/heads/master@{#431312}

Powered by Google App Engine
This is Rietveld 408576698