Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Unified Diff: chrome/browser/ui/cocoa/fullscreen_toolbar_controller.mm

Issue 2491343003: [Mac] Fix for fullscreen toolbar layout issues (Closed)
Patch Set: Added a TODO Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/fullscreen_toolbar_controller.mm
diff --git a/chrome/browser/ui/cocoa/fullscreen_toolbar_controller.mm b/chrome/browser/ui/cocoa/fullscreen_toolbar_controller.mm
index d1f84647fc48098d562a4bddba2c69078fba6f85..cf6bdee4b735fdd3a0db107ddacf5efcc0de3e24 100644
--- a/chrome/browser/ui/cocoa/fullscreen_toolbar_controller.mm
+++ b/chrome/browser/ui/cocoa/fullscreen_toolbar_controller.mm
@@ -60,7 +60,7 @@ const CGFloat kToolbarVerticalOffset = 22;
DCHECK(!inFullscreenMode_);
inFullscreenMode_ = YES;
- [self updateToolbarStyle];
+ [self updateToolbarStyle:NO];
if ([browserController_ isInImmersiveFullscreen]) {
immersiveFullscreenController_.reset([[ImmersiveFullscreenController alloc]
@@ -104,10 +104,11 @@ const CGFloat kToolbarVerticalOffset = 22;
animationController_->AnimateToolbarForTabstripChanges();
}
-- (void)updateToolbarStyle {
+- (void)updateToolbarStyle:(BOOL)isExitingTabFullscreen {
FullscreenToolbarStyle oldStyle = toolbarStyle_;
- if ([browserController_ isFullscreenForTabContentOrExtension]) {
+ if ([browserController_ isFullscreenForTabContentOrExtension] &&
+ !isExitingTabFullscreen) {
toolbarStyle_ = FullscreenToolbarStyle::TOOLBAR_NONE;
} else {
PrefService* prefs = [browserController_ profile]->GetPrefs();

Powered by Google App Engine
This is Rietveld 408576698