[Mac] Fix for fullscreen toolbar layout issues

[Mac] Fix for fullscreen toolbar layout issues

- Fullscreen toolbar style is now updating properly when you exit tab fullscreen
- Info bars should appear under the floatingBarBackingView
- Fullscreen toolbar should be placed above the window's height if the style is
TOOLBAR_NONE. Otherwise, we'll end up with a glimpse of it.

BUG=662734, 608271
Committed: https://crrev.com/47279775a3f42b190afcb962c917a24beb12612b
Cr-Commit-Position: refs/heads/master@{#431676}

[spqchan, 2016-11-11 18:32:26]

Description was changed from

==========
[Mac] Fix for fullscreen issues

BUG=
==========

to

==========
[Mac] Fix for fullscreen issues

BUG= 608271
==========

[spqchan, 2016-11-11 18:50:59]

Patchset #1 (id:1) has been deleted

[spqchan, 2016-11-11 19:00:48]

Description was changed from

==========
[Mac] Fix for fullscreen issues

BUG= 608271
==========

to

==========
[Mac] Fix for fullscreen toolbar layout issues

- Fullscreen toolbar style is now updating properly when you exit tab fullscreen
- Info bars should appear under the floatingBarBackingView
- Fullscreen toolbar should be placed above the window's height if the style is
TOOLBAR_NONE. Otherwise, we'll end up with a glimpse of it.


BUG= 662734, 608271
==========

[spqchan, 2016-11-11 19:00:48]

spqchan@chromium.org changed reviewers:
+ erikchen@chromium.org

[spqchan, 2016-11-11 19:02:50]

PTAL

Let me know if you want me to split this up since I'm tackling multiple issues
in this CL.

[erikchen, 2016-11-11 19:13:58]

lgtm

[spqchan, 2016-11-11 19:19:10]

spqchan@chromium.org changed reviewers:
+ avi@chromium.org

[spqchan, 2016-11-11 19:19:11]

thanks!

+avi for ownership

[spqchan, 2016-11-11 19:19:16]

The CQ bit was checked by spqchan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-11 19:19:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-11 19:53:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-11 19:53:39]

Dry run: This issue passed the CQ dry run.

[Avi (use Gerrit), 2016-11-11 20:45:53]

https://codereview.chromium.org/2491343003/diff/60001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/fullscreen_toolbar_controller.h (right):

https://codereview.chromium.org/2491343003/diff/60001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/fullscreen_toolbar_controller.h:111: -
(void)updateToolbarStyle:(BOOL)isExitingTabFullscreen;
The parameter needs a meaning to the left of the colon. Maybe

-updateToolbarStyleExitingTabFullscreen:

?

[spqchan, 2016-11-11 22:22:14]

PTAL

https://codereview.chromium.org/2491343003/diff/60001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/fullscreen_toolbar_controller.h (right):

https://codereview.chromium.org/2491343003/diff/60001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/fullscreen_toolbar_controller.h:111: -
(void)updateToolbarStyle:(BOOL)isExitingTabFullscreen;
On 2016/11/11 20:45:53, Avi wrote:
> The parameter needs a meaning to the left of the colon. Maybe
> 
> -updateToolbarStyleExitingTabFullscreen:
> 
> ?

Done.

[Avi (use Gerrit), 2016-11-11 22:36:35]

thank you! LGTM

[spqchan, 2016-11-11 22:48:14]

On 2016/11/11 22:36:35, Avi wrote:
> thank you! LGTM

thanks!

[spqchan, 2016-11-11 22:48:18]

The CQ bit was checked by spqchan@chromium.org

[spqchan, 2016-11-11 22:48:18]

The patchset sent to the CQ was uploaded after l-g-t-m from
erikchen@chromium.org
Link to the patchset: https://codereview.chromium.org/2491343003/#ps80001
(title: "Fix for avi")

[commit-bot: I haz the power, 2016-11-11 22:48:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-11 23:10:53]

Description was changed from

==========
[Mac] Fix for fullscreen toolbar layout issues

- Fullscreen toolbar style is now updating properly when you exit tab fullscreen
- Info bars should appear under the floatingBarBackingView
- Fullscreen toolbar should be placed above the window's height if the style is
TOOLBAR_NONE. Otherwise, we'll end up with a glimpse of it.


BUG= 662734, 608271
==========

to

==========
[Mac] Fix for fullscreen toolbar layout issues

- Fullscreen toolbar style is now updating properly when you exit tab fullscreen
- Info bars should appear under the floatingBarBackingView
- Fullscreen toolbar should be placed above the window's height if the style is
TOOLBAR_NONE. Otherwise, we'll end up with a glimpse of it.


BUG= 662734, 608271
==========

[commit-bot: I haz the power, 2016-11-11 23:10:54]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2016-11-11 23:54:16]

Description was changed from

==========
[Mac] Fix for fullscreen toolbar layout issues

- Fullscreen toolbar style is now updating properly when you exit tab fullscreen
- Info bars should appear under the floatingBarBackingView
- Fullscreen toolbar should be placed above the window's height if the style is
TOOLBAR_NONE. Otherwise, we'll end up with a glimpse of it.


BUG= 662734, 608271
==========

to

==========
[Mac] Fix for fullscreen toolbar layout issues

- Fullscreen toolbar style is now updating properly when you exit tab fullscreen
- Info bars should appear under the floatingBarBackingView
- Fullscreen toolbar should be placed above the window's height if the style is
TOOLBAR_NONE. Otherwise, we'll end up with a glimpse of it.

BUG= 662734, 608271

Committed: https://crrev.com/47279775a3f42b190afcb962c917a24beb12612b
Cr-Commit-Position: refs/heads/master@{#431676}
==========

[commit-bot: I haz the power, 2016-11-11 23:54:17]

Patchset 4 (id:??) landed as
https://crrev.com/47279775a3f42b190afcb962c917a24beb12612b
Cr-Commit-Position: refs/heads/master@{#431676}