Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(893)

Issue 2491333003: Use a regular ICU API for el-Upper (Closed)

Created:
4 years, 1 month ago by jungshik at Google
Modified:
4 years, 1 month ago
Reviewers:
Dan Ehrenberg
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Use a regular ICU API for el-Upper ICU now supports uppercasing in Greek via its regular uppercasing API. So, there's no need to use a slow transliteration API for uppercasing in Greek. This CL includes rolling ICU to ICU 58.1. Besides, drop intl402/Intl/getCanonicalLocales/weird-cases from test262.status because it passes now with ICU 58.1. BUG=chromium:637001, v8:5012 Committed: https://crrev.com/4f224b39953ffc6cbac18083790e16785f4c1d5f Cr-Commit-Position: refs/heads/master@{#41009}

Patch Set 1 #

Patch Set 2 : update test262.status #

Patch Set 3 : roll ICU to c1a237113 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -57 lines) Patch
M DEPS View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime-i18n.cc View 1 1 chunk +1 line, -46 lines 0 comments Download
M test/intl/general/case-mapping.js View 1 1 chunk +9 lines, -7 lines 0 comments Download
M test/test262/test262.status View 1 2 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
jungshik at Google
Dan, can you take a look? BTW, somehow DEPS hasn't been rolled since Oct 28(?). ...
4 years, 1 month ago (2016-11-14 23:01:42 UTC) #7
Dan Ehrenberg
lgtm Thanks for the semantic cross-references in the test that explain why the new behavior ...
4 years, 1 month ago (2016-11-15 10:39:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2491333003/40001
4 years, 1 month ago (2016-11-15 17:59:19 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-11-15 18:29:31 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:34:59 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/4f224b39953ffc6cbac18083790e16785f4c1d5f
Cr-Commit-Position: refs/heads/master@{#41009}

Powered by Google App Engine
This is Rietveld 408576698