Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 2491333002: [crankshaft] Always force number representation for increment. (Closed)

Created:
4 years, 1 month ago by Jarin
Modified:
4 years, 1 month ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[crankshaft] Always force number representation for increment. BUG=chromium:664087 Committed: https://crrev.com/c71e5e12943fbce687c751a9c7c8838bee964415 Cr-Commit-Position: refs/heads/master@{#40900}

Patch Set 1 #

Patch Set 2 : Remove redundant parameter #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -19 lines) Patch
M src/crankshaft/hydrogen.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M src/crankshaft/hydrogen.cc View 1 3 chunks +12 lines, -17 lines 0 comments Download
A test/mjsunit/regress/regress-664087.js View 1 chunk +21 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Jarin
Could you take a look, please?
4 years, 1 month ago (2016-11-10 14:09:57 UTC) #5
Jakob Kummerow
lgtm
4 years, 1 month ago (2016-11-10 14:17:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2491333002/20001
4 years, 1 month ago (2016-11-10 14:23:08 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-10 14:51:03 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:29:32 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c71e5e12943fbce687c751a9c7c8838bee964415
Cr-Commit-Position: refs/heads/master@{#40900}

Powered by Google App Engine
This is Rietveld 408576698