Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 2491233002: Make UA DOMActivate events composed events (Closed)

Created:
4 years, 1 month ago by hayato
Modified:
4 years, 1 month ago
Reviewers:
kochi
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make UA DOMActivate events composed events The spec is: https://w3c.github.io/uievents/#event-type-DOMActivate This is basically a bug fix. We forgot to update legacy UI Events in Blink after I updated the UI Events spec at: https://github.com/w3c/uievents/commit/d075314393fad8e07af797dbbab9a5dcfe11ee16 BUG=662657 Committed: https://crrev.com/eaef39e4135d0ea8a18d43e8eec24bb572fdba4d Cr-Commit-Position: refs/heads/master@{#431230}

Patch Set 1 #

Patch Set 2 : wip #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -8 lines) Patch
M third_party/WebKit/LayoutTests/shadow-dom/event-composed-ua.html View 2 chunks +14 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Node.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Node.cpp View 2 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/events/Event.h View 2 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2491233002/1
4 years, 1 month ago (2016-11-10 06:10:09 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 1 month ago (2016-11-10 06:10:10 UTC) #4
hayato
wip
4 years, 1 month ago (2016-11-10 06:12:31 UTC) #5
hayato
PTAL
4 years, 1 month ago (2016-11-10 06:13:17 UTC) #9
kochi
lgtm
4 years, 1 month ago (2016-11-10 07:35:59 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2491233002/20001
4 years, 1 month ago (2016-11-10 07:54:44 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-10 10:31:08 UTC) #15
commit-bot: I haz the power
4 years, 1 month ago (2016-11-10 10:34:07 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/eaef39e4135d0ea8a18d43e8eec24bb572fdba4d
Cr-Commit-Position: refs/heads/master@{#431230}

Powered by Google App Engine
This is Rietveld 408576698