ui/file_manager/audio_player/elements/repeat_button.html - Issue 2491213002: Make the repeat button accessible by keyboard.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ui/file_manager/audio_player/elements/repeat_button.html

Issue 2491213002: Make the repeat button accessible by keyboard. (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « ui/file_manager/audio_player/elements/repeat_button.css ('k') | ui/file_manager/integration_tests/file_manager/open_audio_files.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!-- Copyright 2016 The Chromium Authors. All rights reserved.	1 <!-- Copyright 2016 The Chromium Authors. All rights reserved.

2 -- Use of this source code is governed by a BSD-style license that can be	2 -- Use of this source code is governed by a BSD-style license that can be

3 -- found in the LICENSE file.	3 -- found in the LICENSE file.

4 -->	4 -->

5	5

6 <link rel="import" href="chrome://resources/polymer/v1_0/polymer/polymer.html">	6 <link rel="import" href="chrome://resources/polymer/v1_0/polymer/polymer.html">

7 <link rel="import" href="chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/for eground/elements/files_toggle_ripple.html">	7 <link rel="import" href="chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/for eground/elements/files_icon_button.html">

8	8

9 <dom-module id="repeat-button">	9 <dom-module id="repeat-button">

10 <link rel="import" type="css" href="repeat_button.css">	10 <link rel="import" type="css" href="repeat_button.css">

11 <template>	11 <template>

12 <files-toggle-ripple activated="[[isActive(repeatMode)]]" class$="{{repeatMo de}}"></files-toggle-ripple>	12 <!-- TODO(yamaguchi): Eliminate extra ripple effect upon mouse click. -->
	fukino 2016/11/10 07:09:35 I'm sorry for jumping in this already-agreed appro I'm sorry for jumping in this already-agreed approach! If you don't have a plan to fix this regression at this moment, I think it is better to stick with the previous implementation by copying necessary logic/style from files-icon-button. You can factor out the common parts to shared style and behavior later. yamaguchi 2016/11/10 08:14:53 Resolved the TODO now. I'm sorry, this was very si Show quoted text On 2016/11/10 07:09:35, fukino wrote: > I'm sorry for jumping in this already-agreed approach! > > If you don't have a plan to fix this regression at this moment, I think it is > better to stick with the previous implementation by copying necessary > logic/style from files-icon-button. > You can factor out the common parts to shared style and behavior later. Resolved the TODO now. I'm sorry, this was very simple to fix.
	13 <files-icon-button active="[[isActive(repeatMode)]]"

	14 repeat-mode$="{{repeatMode}}"></files-icon-button>

13 </template>	15 </template>

14	16

15 <script src="repeat_button.js"></script>	17 <script src="repeat_button.js"></script>

16 </dom-module>	18 </dom-module>

OLD	NEW