|
|
Chromium Code Reviews|
Created:
4 years, 1 month ago by dominicc (has gone to gerrit) Modified:
4 years, 1 month ago CC:
blink-reviews, chromium-reviews, telemetry-reviews_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionBackport the long-sibling-list perf test to reference build DOM APIs.
This test uses .append, etc. which isn't available in the reference
build.
BUG=652724
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq
Committed: https://crrev.com/3da78c45b2dd07d644decd03d5bcfc02945f4d5b
Cr-Commit-Position: refs/heads/master@{#432522}
Patch Set 1 #Patch Set 2 : Iterate fewer times to avoid timeouts on mobile devices. #
Messages
Total messages: 39 (22 generated)
Description was changed from ========== Backport the long-sibling-list perf test to reference build DOM APIs. This test uses .append, etc. which isn't available in the reference build. BUG=652724 ========== to ========== Backport the long-sibling-list perf test to reference build DOM APIs. This test uses .append, etc. which isn't available in the reference build. BUG=652724 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ==========
The CQ bit was checked by dominicc@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
dominicc@chromium.org changed reviewers: + eyaich@chromium.org
Sorry I broke things, PTAL.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_s5_perf_cq on master.tryserver.chromium.perf (JOB_TIMED_OUT, http://build.chromium.org/p/tryserver.chromium.perf/builders/android_s5_perf_...)
The CQ bit was checked by eyaich@chromium.org
lgtm Thanks for following up!
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
eyaich@chromium.org changed reviewers: + nednguyen@google.com
+ Ned for ownership in tools/perf
lgtm
The CQ bit was checked by eyaich@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
The CQ bit was checked by eyaich@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_s5_perf_cq on master.tryserver.chromium.perf (JOB_TIMED_OUT, no build URL)
Description was changed from ========== Backport the long-sibling-list perf test to reference build DOM APIs. This test uses .append, etc. which isn't available in the reference build. BUG=652724 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ========== to ========== Backport the long-sibling-list perf test to reference build DOM APIs. This test uses .append, etc. which isn't available in the reference build. BUG=652724 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ==========
The CQ bit was checked by nednguyen@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_perf_cq on master.tryserver.chromium.perf (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by dominicc@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from nednguyen@google.com, eyaich@chromium.org Link to the patchset: https://codereview.chromium.org/2491203002/#ps20001 (title: "Iterate fewer times to avoid timeouts on mobile devices.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by nednguyen@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Backport the long-sibling-list perf test to reference build DOM APIs. This test uses .append, etc. which isn't available in the reference build. BUG=652724 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ========== to ========== Backport the long-sibling-list perf test to reference build DOM APIs. This test uses .append, etc. which isn't available in the reference build. BUG=652724 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Backport the long-sibling-list perf test to reference build DOM APIs. This test uses .append, etc. which isn't available in the reference build. BUG=652724 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ========== to ========== Backport the long-sibling-list perf test to reference build DOM APIs. This test uses .append, etc. which isn't available in the reference build. BUG=652724 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq Committed: https://crrev.com/3da78c45b2dd07d644decd03d5bcfc02945f4d5b Cr-Commit-Position: refs/heads/master@{#432522} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/3da78c45b2dd07d644decd03d5bcfc02945f4d5b Cr-Commit-Position: refs/heads/master@{#432522} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
