Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 2491203002: Backport the long-sibling-list perf test to reference build DOM APIs. (Closed)

Created:
4 years, 1 month ago by dominicc (has gone to gerrit)
Modified:
4 years, 1 month ago
Reviewers:
nednguyen, eyaich1
CC:
blink-reviews, chromium-reviews, telemetry-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Backport the long-sibling-list perf test to reference build DOM APIs. This test uses .append, etc. which isn't available in the reference build. BUG=652724 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq Committed: https://crrev.com/3da78c45b2dd07d644decd03d5bcfc02945f4d5b Cr-Commit-Position: refs/heads/master@{#432522}

Patch Set 1 #

Patch Set 2 : Iterate fewer times to avoid timeouts on mobile devices. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -15 lines) Patch
M third_party/WebKit/PerformanceTests/DOM/long-sibling-list.html View 1 1 chunk +6 lines, -6 lines 0 comments Download
M tools/perf/benchmarks/blink_perf.py View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 39 (22 generated)
dominicc (has gone to gerrit)
Sorry I broke things, PTAL.
4 years, 1 month ago (2016-11-10 05:07:02 UTC) #5
eyaich1
lgtm Thanks for following up!
4 years, 1 month ago (2016-11-10 15:37:39 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2491203002/1
4 years, 1 month ago (2016-11-10 15:37:55 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/301396)
4 years, 1 month ago (2016-11-10 15:44:07 UTC) #12
eyaich1
+ Ned for ownership in tools/perf
4 years, 1 month ago (2016-11-10 15:52:55 UTC) #14
nednguyen
lgtm
4 years, 1 month ago (2016-11-10 15:53:57 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2491203002/1
4 years, 1 month ago (2016-11-14 16:37:22 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/66973)
4 years, 1 month ago (2016-11-14 17:52:35 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2491203002/1
4 years, 1 month ago (2016-11-15 16:50:56 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: android_s5_perf_cq on master.tryserver.chromium.perf (JOB_TIMED_OUT, no build URL)
4 years, 1 month ago (2016-11-15 18:52:49 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2491203002/1
4 years, 1 month ago (2016-11-15 21:49:11 UTC) #26
commit-bot: I haz the power
Try jobs failed on following builders: linux_perf_cq on master.tryserver.chromium.perf (JOB_TIMED_OUT, no build URL)
4 years, 1 month ago (2016-11-15 23:50:21 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2491203002/20001
4 years, 1 month ago (2016-11-16 01:55:02 UTC) #31
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/338255)
4 years, 1 month ago (2016-11-16 03:36:50 UTC) #33
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2491203002/20001
4 years, 1 month ago (2016-11-16 14:09:08 UTC) #35
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-16 16:57:12 UTC) #37
commit-bot: I haz the power
4 years, 1 month ago (2016-11-16 17:18:05 UTC) #39
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3da78c45b2dd07d644decd03d5bcfc02945f4d5b
Cr-Commit-Position: refs/heads/master@{#432522}

Powered by Google App Engine
This is Rietveld 408576698