Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Issue 2491173002: Rename setters VariableElementImpl.[const3, final2] to isConst and isFinal. (Closed)

Created:
4 years, 1 month ago by scheglov
Modified:
4 years, 1 month ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Rename setters VariableElementImpl.[const3, final2] to isConst and isFinal. This is a breaking change. R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/c50b82abccc64410e9d346a614aab4127483826a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -80 lines) Patch
M pkg/analyzer/lib/src/dart/element/builder.dart View 11 chunks +17 lines, -17 lines 0 comments Download
M pkg/analyzer/lib/src/dart/element/element.dart View 15 chunks +49 lines, -49 lines 0 comments Download
M pkg/analyzer/lib/src/generated/resolver.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/generated/testing/element_factory.dart View 5 chunks +9 lines, -9 lines 0 comments Download
M pkg/analyzer/lib/src/summary/resynthesize.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analyzer/test/src/dart/constant/utilities_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
scheglov
4 years, 1 month ago (2016-11-10 03:52:36 UTC) #1
Brian Wilkerson
lgtm
4 years, 1 month ago (2016-11-10 14:41:24 UTC) #2
Paul Berry
lgtm
4 years, 1 month ago (2016-11-10 16:28:04 UTC) #3
scheglov
4 years, 1 month ago (2016-11-10 16:46:40 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c50b82abccc64410e9d346a614aab4127483826a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698