Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1590)

Issue 2491163002: Log to the console when a dialog is suppressed or would be. (Closed)

Created:
4 years, 1 month ago by Avi (use Gerrit)
Modified:
4 years, 1 month ago
Reviewers:
dknox1, Rick Byers, ojan
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Log to the console when a dialog is suppressed or would be. BUG=629964 Committed: https://crrev.com/7484f1a2039a73e59ae812d6a15e21023c9827c7 Cr-Commit-Position: refs/heads/master@{#431457}

Patch Set 1 #

Patch Set 2 : phrasing! #

Total comments: 8

Patch Set 3 : rewording #

Patch Set 4 : drop the second one #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.cc View 1 2 3 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 22 (14 generated)
Avi (use Gerrit)
4 years, 1 month ago (2016-11-10 02:54:23 UTC) #6
Rick Byers
https://codereview.chromium.org/2491163002/diff/20001/chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.cc File chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.cc (right): https://codereview.chromium.org/2491163002/diff/20001/chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.cc#newcode94 chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.cc:94: "Please do not use dialogs to force browser windows ...
4 years, 1 month ago (2016-11-10 04:18:39 UTC) #9
Avi (use Gerrit)
In the email thread "Making official Chromium policy" that you're on, I've been trying to ...
4 years, 1 month ago (2016-11-10 04:36:13 UTC) #10
Avi (use Gerrit)
https://codereview.chromium.org/2491163002/diff/20001/chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.cc File chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.cc (right): https://codereview.chromium.org/2491163002/diff/20001/chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.cc#newcode94 chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.cc:94: "Please do not use dialogs to force browser windows ...
4 years, 1 month ago (2016-11-10 21:04:30 UTC) #13
Rick Byers
LGTM if you split out the 2nd warning https://codereview.chromium.org/2491163002/diff/20001/chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.cc File chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.cc (right): https://codereview.chromium.org/2491163002/diff/20001/chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.cc#newcode94 chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.cc:94: "Please ...
4 years, 1 month ago (2016-11-11 00:43:33 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2491163002/60001
4 years, 1 month ago (2016-11-11 01:10:47 UTC) #19
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 1 month ago (2016-11-11 02:00:04 UTC) #20
commit-bot: I haz the power
4 years, 1 month ago (2016-11-11 02:14:20 UTC) #22
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/7484f1a2039a73e59ae812d6a15e21023c9827c7
Cr-Commit-Position: refs/heads/master@{#431457}

Powered by Google App Engine
This is Rietveld 408576698