[inspector] Change ScriptBreakpoint to include scriptId

src/inspector/script-breakpoint.h

Index: src/inspector/script-breakpoint.h
diff --git a/src/inspector/script-breakpoint.h b/src/inspector/script-breakpoint.h
index 025233dd19e802ff6be0c31408c5a2897614678c..a981b1626ce824bb0eb530e906a33d9b099a96be 100644
--- a/src/inspector/script-breakpoint.h
+++ b/src/inspector/script-breakpoint.h
@@ -35,15 +35,18 @@
 namespace v8_inspector {
 
 struct ScriptBreakpoint {
-  ScriptBreakpoint() : ScriptBreakpoint(0, 0, String16()) {}
-
-  ScriptBreakpoint(int lineNumber, int columnNumber, const String16& condition)
-      : lineNumber(lineNumber),
-        columnNumber(columnNumber),
-        condition(condition) {}
-
-  int lineNumber;
-  int columnNumber;
+  ScriptBreakpoint() {}
+
+  ScriptBreakpoint(String16 script_id, int line_number, int column_number,

[Yang, 2016/11/15 07:49:18]

I'm very surprised that the script_id is a string. On V8's end the script id is
just an integer.

[Clemens Hammacher, 2016/11/15 08:46:01]

In the frontend, it's a string everywhere. This is quite fortunate for the
wasm-translation, since we don't need to worry about clashes with script ids
assigned by V8.

[kozy, 2016/11/15 23:29:47]

In protocol we prefer to have string as a type for all ids.

+                   String16 condition)
+      : script_id(std::move(script_id)),
+        line_number(line_number),
+        column_number(column_number),
+        condition(std::move(condition)) {}
+
+  String16 script_id;
+  int line_number = 0;
+  int column_number = 0;
   String16 condition;
 };