Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Side by Side Diff: src/inspector/v8-debugger-agent-impl.h

Issue 2491133003: [inspector] Change ScriptBreakpoint to include scriptId (Closed)
Patch Set: Address comments Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/inspector/v8-debugger.cc ('k') | src/inspector/v8-debugger-agent-impl.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 the V8 project authors. All rights reserved. 1 // Copyright 2015 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_INSPECTOR_V8DEBUGGERAGENTIMPL_H_ 5 #ifndef V8_INSPECTOR_V8DEBUGGERAGENTIMPL_H_
6 #define V8_INSPECTOR_V8DEBUGGERAGENTIMPL_H_ 6 #define V8_INSPECTOR_V8DEBUGGERAGENTIMPL_H_
7 7
8 #include <vector> 8 #include <vector>
9 9
10 #include "src/base/macros.h" 10 #include "src/base/macros.h"
(...skipping 144 matching lines...) Expand 10 before | Expand all | Expand 10 after
155 155
156 Response currentCallFrames( 156 Response currentCallFrames(
157 std::unique_ptr<protocol::Array<protocol::Debugger::CallFrame>>*); 157 std::unique_ptr<protocol::Array<protocol::Debugger::CallFrame>>*);
158 std::unique_ptr<protocol::Runtime::StackTrace> currentAsyncStackTrace(); 158 std::unique_ptr<protocol::Runtime::StackTrace> currentAsyncStackTrace();
159 159
160 void changeJavaScriptRecursionLevel(int step); 160 void changeJavaScriptRecursionLevel(int step);
161 161
162 void setPauseOnExceptionsImpl(int); 162 void setPauseOnExceptionsImpl(int);
163 163
164 std::unique_ptr<protocol::Debugger::Location> resolveBreakpoint( 164 std::unique_ptr<protocol::Debugger::Location> resolveBreakpoint(
165 const String16& breakpointId, const String16& scriptId, 165 const String16& breakpointId, const ScriptBreakpoint&, BreakpointSource);
166 const ScriptBreakpoint&, BreakpointSource);
167 void removeBreakpointImpl(const String16& breakpointId); 166 void removeBreakpointImpl(const String16& breakpointId);
168 void clearBreakDetails(); 167 void clearBreakDetails();
169 168
170 bool isCurrentCallStackEmptyOrBlackboxed(); 169 bool isCurrentCallStackEmptyOrBlackboxed();
171 bool isTopPausedCallFrameBlackboxed(); 170 bool isTopPausedCallFrameBlackboxed();
172 bool isCallFrameWithUnknownScriptOrBlackboxed(JavaScriptCallFrame*); 171 bool isCallFrameWithUnknownScriptOrBlackboxed(JavaScriptCallFrame*);
173 172
174 void internalSetAsyncCallStackDepth(int); 173 void internalSetAsyncCallStackDepth(int);
175 void increaseCachedSkipStackGeneration(); 174 void increaseCachedSkipStackGeneration();
176 175
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
215 std::unique_ptr<V8Regex> m_blackboxPattern; 214 std::unique_ptr<V8Regex> m_blackboxPattern;
216 protocol::HashMap<String16, std::vector<std::pair<int, int>>> 215 protocol::HashMap<String16, std::vector<std::pair<int, int>>>
217 m_blackboxedPositions; 216 m_blackboxedPositions;
218 217
219 DISALLOW_COPY_AND_ASSIGN(V8DebuggerAgentImpl); 218 DISALLOW_COPY_AND_ASSIGN(V8DebuggerAgentImpl);
220 }; 219 };
221 220
222 } // namespace v8_inspector 221 } // namespace v8_inspector
223 222
224 #endif // V8_INSPECTOR_V8DEBUGGERAGENTIMPL_H_ 223 #endif // V8_INSPECTOR_V8DEBUGGERAGENTIMPL_H_
OLDNEW
« no previous file with comments | « src/inspector/v8-debugger.cc ('k') | src/inspector/v8-debugger-agent-impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698