Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Side by Side Diff: src/inspector/script-breakpoint.h

Issue 2491133003: [inspector] Change ScriptBreakpoint to include scriptId (Closed)
Patch Set: Address comments Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/inspector/v8-debugger.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Apple Inc. All rights reserved. 2 * Copyright (C) 2009 Apple Inc. All rights reserved.
3 * Copyright (C) 2009 Google Inc. All rights reserved. 3 * Copyright (C) 2009 Google Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 8 *
9 * 1. Redistributions of source code must retain the above copyright 9 * 1. Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 17 matching lines...) Expand all
28 */ 28 */
29 29
30 #ifndef V8_INSPECTOR_SCRIPTBREAKPOINT_H_ 30 #ifndef V8_INSPECTOR_SCRIPTBREAKPOINT_H_
31 #define V8_INSPECTOR_SCRIPTBREAKPOINT_H_ 31 #define V8_INSPECTOR_SCRIPTBREAKPOINT_H_
32 32
33 #include "src/inspector/string-16.h" 33 #include "src/inspector/string-16.h"
34 34
35 namespace v8_inspector { 35 namespace v8_inspector {
36 36
37 struct ScriptBreakpoint { 37 struct ScriptBreakpoint {
38 ScriptBreakpoint() : ScriptBreakpoint(0, 0, String16()) {} 38 ScriptBreakpoint() {}
39 39
40 ScriptBreakpoint(int lineNumber, int columnNumber, const String16& condition) 40 ScriptBreakpoint(String16 script_id, int line_number, int column_number,
41 : lineNumber(lineNumber), 41 String16 condition)
42 columnNumber(columnNumber), 42 : script_id(std::move(script_id)),
43 condition(condition) {} 43 line_number(line_number),
44 column_number(column_number),
45 condition(std::move(condition)) {}
44 46
45 int lineNumber; 47 String16 script_id;
46 int columnNumber; 48 int line_number = 0;
49 int column_number = 0;
47 String16 condition; 50 String16 condition;
48 }; 51 };
49 52
50 } // namespace v8_inspector 53 } // namespace v8_inspector
51 54
52 #endif // V8_INSPECTOR_SCRIPTBREAKPOINT_H_ 55 #endif // V8_INSPECTOR_SCRIPTBREAKPOINT_H_
OLDNEW
« no previous file with comments | « no previous file | src/inspector/v8-debugger.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698