Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 249113004: Use textContent instead of innerText. (Closed)

Created:
6 years, 8 months ago by jcgregorio
Modified:
6 years, 8 months ago
Reviewers:
mtklein
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Use textContent instead of innerText. BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=14331

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M experimental/webtry/js/run.js View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
jcgregorio
6 years, 8 months ago (2014-04-23 14:14:49 UTC) #1
mtklein
On 2014/04/23 14:14:49, jcgregorio wrote: Oh boy, I started reading http://clubajax.org/plain-text-vs-innertext-vs-textcontent/ and my brain shut ...
6 years, 8 months ago (2014-04-23 14:38:58 UTC) #2
jcgregorio
The CQ bit was checked by jcgregorio@google.com
6 years, 8 months ago (2014-04-23 14:42:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/jcgregorio@google.com/249113004/1
6 years, 8 months ago (2014-04-23 14:42:15 UTC) #4
jcgregorio
Yeah, in this case we are only setting, and are only dealing with a single ...
6 years, 8 months ago (2014-04-23 14:43:32 UTC) #5
commit-bot: I haz the power
6 years, 8 months ago (2014-04-23 19:18:17 UTC) #6
Message was sent while issue was closed.
Change committed as 14331

Powered by Google App Engine
This is Rietveld 408576698