[DevTools] Force contexts initialization in OOPIF case.

[DevTools] Force contexts initialization in OOPIF case.

This happens when you connect DevTools to the page without context.

Previously, we checked for the main frame being a local frame.
Now we force for every local frame in the subtree.

BUG=652783
Committed: https://crrev.com/d61cd0b7c463ee9907c8fb90b22a11c19829e486
Cr-Commit-Position: refs/heads/master@{#431082}

[dgozman, 2016-11-09 20:01:11]

dgozman@chromium.org changed reviewers:
+ dcheng@chromium.org

[dgozman, 2016-11-09 20:01:12]

Could you please take a look?

I tried to add a test, but it turned out to be too complex (you have to attach
to main frame, discover oopif, attach to it and then wait for execution context
to be created). I guess we need an ability to easily write a layout test with
oopif.

[dcheng, 2016-11-09 21:53:42]

change lgtm but can you help me understand why we need to do this for every
local frame in the tree?

[dgozman, 2016-11-09 22:08:10]

On 2016/11/09 21:53:42, dcheng wrote:
> change lgtm but can you help me understand why we need to do this for every
> local frame in the tree?

We force contexts to be created in all frames when you open DevTools. This makes
it possible to select specific context in Console combobox and evaluate
something.
Since we have DevTools per local frame root, we handle all local frames at the
same time.

Does this answer your question? Feel free to ask more :-)

[dcheng, 2016-11-09 22:10:02]

On 2016/11/09 22:08:10, dgozman wrote:
> On 2016/11/09 21:53:42, dcheng wrote:
> > change lgtm but can you help me understand why we need to do this for every
> > local frame in the tree?
> 
> We force contexts to be created in all frames when you open DevTools. This
makes
> it possible to select specific context in Console combobox and evaluate
> something.
> Since we have DevTools per local frame root, we handle all local frames at the
> same time.
> 
> Does this answer your question? Feel free to ask more :-)

OK, makes sense! No more questions =)

[dgozman, 2016-11-09 22:27:20]

The CQ bit was checked by dgozman@chromium.org

[commit-bot: I haz the power, 2016-11-09 22:27:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-09 23:42:39]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-09 23:51:16]

Description was changed from

==========
[DevTools] Force contexts initialization in OOPIF case.

This happens when you connect DevTools to the page without context.

Previously, we checked for the main frame being a local frame.
Now we force for every local frame in the subtree.

BUG=652783
==========

to

==========
[DevTools] Force contexts initialization in OOPIF case.

This happens when you connect DevTools to the page without context.

Previously, we checked for the main frame being a local frame.
Now we force for every local frame in the subtree.

BUG=652783

Committed: https://crrev.com/d61cd0b7c463ee9907c8fb90b22a11c19829e486
Cr-Commit-Position: refs/heads/master@{#431082}
==========

[commit-bot: I haz the power, 2016-11-09 23:51:17]

Patchset 1 (id:??) landed as
https://crrev.com/d61cd0b7c463ee9907c8fb90b22a11c19829e486
Cr-Commit-Position: refs/heads/master@{#431082}