Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(703)

Unified Diff: chromecast/media/service/cast_renderer.cc

Issue 2491043003: MediaResource refactoring to support multiple streams (Closed)
Patch Set: Added a TODO about DemuxerStream enabled/set_enabled methods Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromecast/media/cma/test/frame_segmenter_for_test.cc ('k') | media/base/demuxer_perftest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromecast/media/service/cast_renderer.cc
diff --git a/chromecast/media/service/cast_renderer.cc b/chromecast/media/service/cast_renderer.cc
index 5c30c5eb7dc790291f862d99c81d6f582fbeea5d..be4b991f5bf5d98b20b25024f2b50f2224a41477 100644
--- a/chromecast/media/service/cast_renderer.cc
+++ b/chromecast/media/service/cast_renderer.cc
@@ -105,9 +105,14 @@ void CastRenderer::Initialize(::media::MediaResource* media_resource,
pipeline_->SetClient(pipeline_client);
pipeline_->Initialize(load_type, std::move(backend));
- // Initialize audio.
+ // TODO(servolk): Implement support for multiple streams. For now use the
+ // first enabled audio and video streams to preserve the existing behavior.
::media::DemuxerStream* audio_stream =
- media_resource->GetStream(::media::DemuxerStream::AUDIO);
+ media_resource->GetFirstStream(::media::DemuxerStream::AUDIO);
+ ::media::DemuxerStream* video_stream =
+ media_resource->GetFirstStream(::media::DemuxerStream::VIDEO);
+
+ // Initialize audio.
if (audio_stream) {
AvPipelineClient audio_client;
audio_client.wait_for_key_cb = base::Bind(
@@ -132,8 +137,6 @@ void CastRenderer::Initialize(::media::MediaResource* media_resource,
}
// Initialize video.
- ::media::DemuxerStream* video_stream =
- media_resource->GetStream(::media::DemuxerStream::VIDEO);
if (video_stream) {
VideoPipelineClient video_client;
video_client.av_pipeline_client.wait_for_key_cb = base::Bind(
« no previous file with comments | « chromecast/media/cma/test/frame_segmenter_for_test.cc ('k') | media/base/demuxer_perftest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698