Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Side by Side Diff: media/base/demuxer_stream.h

Issue 2491043003: MediaResource refactoring to support multiple streams (Closed)
Patch Set: Added a TODO about DemuxerStream enabled/set_enabled methods Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « media/base/demuxer_perftest.cc ('k') | media/base/fake_demuxer_stream.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef MEDIA_BASE_DEMUXER_STREAM_H_ 5 #ifndef MEDIA_BASE_DEMUXER_STREAM_H_
6 #define MEDIA_BASE_DEMUXER_STREAM_H_ 6 #define MEDIA_BASE_DEMUXER_STREAM_H_
7 7
8 #include "base/callback.h" 8 #include "base/callback.h"
9 #include "base/memory/ref_counted.h" 9 #include "base/memory/ref_counted.h"
10 #include "base/time/time.h" 10 #include "base/time/time.h"
(...skipping 76 matching lines...) Expand 10 before | Expand all | Expand 10 after
87 // A DemuxerStream that returns 'true' to this may return the 'kConfigChange' 87 // A DemuxerStream that returns 'true' to this may return the 'kConfigChange'
88 // status from a Read() call. In this case the client is expected to be 88 // status from a Read() call. In this case the client is expected to be
89 // capable of taking appropriate action to handle config changes. Otherwise 89 // capable of taking appropriate action to handle config changes. Otherwise
90 // audio_decoder_config() and video_decoder_config()'s return values are 90 // audio_decoder_config() and video_decoder_config()'s return values are
91 // guaranteed to remain constant, and the client may make optimizations based 91 // guaranteed to remain constant, and the client may make optimizations based
92 // on this. 92 // on this.
93 virtual bool SupportsConfigChanges() = 0; 93 virtual bool SupportsConfigChanges() = 0;
94 94
95 virtual VideoRotation video_rotation() = 0; 95 virtual VideoRotation video_rotation() = 0;
96 96
97 // TODO(servolk): Remove enabled / set_enabled methods from DemuxerStream
98 // interface, since those are only called from demuxers.
99
97 // Indicates whether a DemuxerStream is currently enabled (i.e. should be 100 // Indicates whether a DemuxerStream is currently enabled (i.e. should be
98 // decoded and rendered) or not. 101 // decoded and rendered) or not.
99 virtual bool enabled() const = 0; 102 virtual bool enabled() const = 0;
100 103
101 // Disables and re-enables the stream. Reading from a disabled stream will 104 // Disables and re-enables the stream. Reading from a disabled stream will
102 // return an end-of-stream (EOS) buffer. When a stream is re-enabled, it needs 105 // return an end-of-stream (EOS) buffer. When a stream is re-enabled, it needs
103 // to know the current playback position |timestamp| in order to resume 106 // to know the current playback position |timestamp| in order to resume
104 // reading data from a key frame preceeding the |timestamp|. 107 // reading data from a key frame preceeding the |timestamp|.
105 virtual void set_enabled(bool enabled, base::TimeDelta timestamp) = 0; 108 virtual void set_enabled(bool enabled, base::TimeDelta timestamp) = 0;
106 109
107 // The StreamStatusChangeCB allows DemuxerStream clients to receive
108 // notifications about the stream being disabled or enabled.
109 // The first parameter indicates whether the stream is enabled or disabled.
110 // The second parameter is the playback position when the change occured.
111 using StreamStatusChangeCB = base::Callback<void(bool, base::TimeDelta)>;
112 virtual void SetStreamStatusChangeCB(const StreamStatusChangeCB& cb) = 0;
113
114 protected: 110 protected:
115 // Only allow concrete implementations to get deleted. 111 // Only allow concrete implementations to get deleted.
116 virtual ~DemuxerStream(); 112 virtual ~DemuxerStream();
117 }; 113 };
118 114
119 } // namespace media 115 } // namespace media
120 116
121 #endif // MEDIA_BASE_DEMUXER_STREAM_H_ 117 #endif // MEDIA_BASE_DEMUXER_STREAM_H_
OLDNEW
« no previous file with comments | « media/base/demuxer_perftest.cc ('k') | media/base/fake_demuxer_stream.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698