Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(514)

Issue 2490993002: Adjust line endings setting in .gitattributes (Closed)

Created:
4 years, 1 month ago by zra
Modified:
4 years, 1 month ago
Reviewers:
Cutch, siva
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Adjust line endings setting in .gitattributes When checking out code on Windows, we have git set up to automagically convert LF line-endings to CRLF line-endings. This confuses the canned formatting presubmit check, which fails because the line endings are not what it wants. This CL turns off the automagic line-ending conversion for C/C++ source files, so that clang-format doesn't get confused by them on Windows. R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/eba3743adb2fb1027063c09088802ace11d05ea8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M .gitattributes View 1 chunk +6 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
zra
4 years, 1 month ago (2016-11-09 17:02:52 UTC) #2
Cutch
lgtm
4 years, 1 month ago (2016-11-09 17:03:35 UTC) #3
zra
4 years, 1 month ago (2016-11-09 17:23:26 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
eba3743adb2fb1027063c09088802ace11d05ea8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698