Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issue 2490903002: Simplify accesses to Script::line_ends (Closed)

Created:
4 years, 1 month ago by jgruber
Modified:
4 years, 1 month ago
Reviewers:
kozy, Yang
CC:
v8-reviews_googlegroups.com, devtools-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Simplify accesses to Script::line_ends line_ends is either undefined (if uninitialized) or a fixed array (after Script::InitLineEnds). All accesses from JS have been removed, therefore we can skip assigning a COW map and remove the accessor. Committed: https://crrev.com/e730d08846d9800c9e3ae8b75d32b9769982c89c Cr-Commit-Position: refs/heads/master@{#40876}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -74 lines) Patch
M src/accessors.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/accessors.cc View 1 chunk +0 lines, -34 lines 0 comments Download
M src/api.cc View 1 1 chunk +8 lines, -14 lines 0 comments Download
M src/bootstrapper.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M src/inspector/debugger_script_externs.js View 1 chunk +0 lines, -1 line 0 comments Download
M src/objects.cc View 1 chunk +9 lines, -15 lines 0 comments Download

Messages

Total messages: 18 (12 generated)
jgruber
4 years, 1 month ago (2016-11-09 09:23:24 UTC) #4
Yang
lgtm. awesome. https://codereview.chromium.org/2490903002/diff/1/src/api.cc File src/api.cc (right): https://codereview.chromium.org/2490903002/diff/1/src/api.cc#newcode8892 src/api.cc:8892: result.push_back(line_end->value()); since we already know the resulting ...
4 years, 1 month ago (2016-11-09 09:29:18 UTC) #5
kozy
lgtm
4 years, 1 month ago (2016-11-09 17:40:06 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2490903002/20001
4 years, 1 month ago (2016-11-10 07:57:25 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-10 07:59:48 UTC) #16
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:28:17 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e730d08846d9800c9e3ae8b75d32b9769982c89c
Cr-Commit-Position: refs/heads/master@{#40876}

Powered by Google App Engine
This is Rietveld 408576698