Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(446)

Issue 2490883002: Make UA dblclick events composed events (Closed)

Created:
4 years, 1 month ago by hayato
Modified:
4 years, 1 month ago
Reviewers:
kochi
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make UA dblclick events composed events This is a bug fix. BUG=662401 Committed: https://crrev.com/0eec66d250f63a4802bf17b0d0b84a8ddeda91f6 Cr-Commit-Position: refs/heads/master@{#431172}

Patch Set 1 #

Total comments: 2

Patch Set 2 : update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -0 lines) Patch
M third_party/WebKit/LayoutTests/shadow-dom/event-composed-ua.html View 1 1 chunk +16 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/events/Event.h View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/events/MouseEvent.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
hayato
PTAL
4 years, 1 month ago (2016-11-09 08:48:47 UTC) #5
kochi
LGTM % a nit https://codereview.chromium.org/2490883002/diff/1/third_party/WebKit/LayoutTests/shadow-dom/event-composed-ua.html File third_party/WebKit/LayoutTests/shadow-dom/event-composed-ua.html (right): https://codereview.chromium.org/2490883002/diff/1/third_party/WebKit/LayoutTests/shadow-dom/event-composed-ua.html#newcode76 third_party/WebKit/LayoutTests/shadow-dom/event-composed-ua.html:76: }, 'dblclick'); Could you make ...
4 years, 1 month ago (2016-11-09 09:22:11 UTC) #6
hayato
update
4 years, 1 month ago (2016-11-10 00:59:32 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2490883002/20001
4 years, 1 month ago (2016-11-10 01:00:10 UTC) #12
hayato
https://codereview.chromium.org/2490883002/diff/1/third_party/WebKit/LayoutTests/shadow-dom/event-composed-ua.html File third_party/WebKit/LayoutTests/shadow-dom/event-composed-ua.html (right): https://codereview.chromium.org/2490883002/diff/1/third_party/WebKit/LayoutTests/shadow-dom/event-composed-ua.html#newcode76 third_party/WebKit/LayoutTests/shadow-dom/event-composed-ua.html:76: }, 'dblclick'); Done
4 years, 1 month ago (2016-11-10 01:00:21 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-10 03:50:07 UTC) #14
commit-bot: I haz the power
4 years, 1 month ago (2016-11-10 03:53:49 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0eec66d250f63a4802bf17b0d0b84a8ddeda91f6
Cr-Commit-Position: refs/heads/master@{#431172}

Powered by Google App Engine
This is Rietveld 408576698