Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issue 2490833002: [Mac] Fix tools menu button spacing when no extensions installed. (Closed)

Created:
4 years, 1 month ago by shrike
Modified:
4 years, 1 month ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac] Fix tools menu button spacing when no extensions installed. This cl corrects the spacing between the omnibox and the tools menu button when there are no extension installed. Before the fix, the button was 2pt too close to the omnibox. R=avi@chromium.org BUG=634918 Committed: https://crrev.com/a1b59c4930b456e8bc36574631fba03a77e38a15 Cr-Commit-Position: refs/heads/master@{#431017}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
shrike
PTAL
4 years, 1 month ago (2016-11-09 01:01:38 UTC) #1
Avi (use Gerrit)
lgtm
4 years, 1 month ago (2016-11-09 15:48:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2490833002/1
4 years, 1 month ago (2016-11-09 19:28:05 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-09 20:04:06 UTC) #5
commit-bot: I haz the power
4 years, 1 month ago (2016-11-09 20:15:00 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a1b59c4930b456e8bc36574631fba03a77e38a15
Cr-Commit-Position: refs/heads/master@{#431017}

Powered by Google App Engine
This is Rietveld 408576698