Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(763)

Unified Diff: native_client_sdk/src/build_tools/build_sdk.py

Issue 2490823003: [NaCl SDK] Update the make_pnacl_component script to GN (Closed)
Patch Set: use x86 instead of ia32 Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | native_client_sdk/src/build_tools/make_pnacl_component.sh » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: native_client_sdk/src/build_tools/build_sdk.py
diff --git a/native_client_sdk/src/build_tools/build_sdk.py b/native_client_sdk/src/build_tools/build_sdk.py
index 93db6d54fcd4d2affdf45915952410fe82c92a34..55f29cfc676766d23429ffc16833a13b06fb7070 100755
--- a/native_client_sdk/src/build_tools/build_sdk.py
+++ b/native_client_sdk/src/build_tools/build_sdk.py
@@ -849,11 +849,8 @@ def main(args):
if options.tar:
BuildStepTarBundle(pepper_ver, tarfile)
- # TODO(sbc): Re-enable this once we switch the pnacl component build
- # from gyp to gn:
- # https://bugs.chromium.org/p/chromium/issues/detail?id=646241
- #if platform == 'linux':
- #BuildStepBuildPNaClComponent(pepper_ver, chrome_revision)
+ if platform == 'linux':
+ BuildStepBuildPNaClComponent(pepper_ver, chrome_revision)
if options.build_app_engine and platform == 'linux':
BuildStepBuildAppEngine(pepperdir, chrome_revision)
« no previous file with comments | « no previous file | native_client_sdk/src/build_tools/make_pnacl_component.sh » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698