Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Issue 2490823003: [NaCl SDK] Update the make_pnacl_component script to GN (Closed)

Created:
4 years, 1 month ago by binji
Modified:
4 years, 1 month ago
Reviewers:
bradnelson
CC:
chromium-reviews, binji+watch_chromium.org, Sam Clegg, stichnot1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[NaCl SDK] Update the make_pnacl_component script to GN BUG=646241 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_nacl_sdk;master.tryserver.chromium.mac:mac_nacl_sdk;master.tryserver.chromium.win:win_nacl_sdk Committed: https://crrev.com/19e2d778ca6749beffefb026d17fe88744d81228 Cr-Commit-Position: refs/heads/master@{#431141}

Patch Set 1 #

Patch Set 2 : use x86 instead of ia32 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -35 lines) Patch
M native_client_sdk/src/build_tools/build_sdk.py View 1 chunk +2 lines, -5 lines 0 comments Download
M native_client_sdk/src/build_tools/make_pnacl_component.sh View 1 2 chunks +17 lines, -30 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
binji
PTAL, seems to be working.
4 years, 1 month ago (2016-11-10 00:36:54 UTC) #3
bradnelson
lgtm
4 years, 1 month ago (2016-11-10 00:44:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2490823003/20001
4 years, 1 month ago (2016-11-10 00:45:02 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-10 02:11:07 UTC) #8
commit-bot: I haz the power
4 years, 1 month ago (2016-11-10 02:13:46 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/19e2d778ca6749beffefb026d17fe88744d81228
Cr-Commit-Position: refs/heads/master@{#431141}

Powered by Google App Engine
This is Rietveld 408576698