Issue 2490803002: DBC: Fix bugs with array allocation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2490803002: DBC: Fix bugs with array allocation (Closed)

Created:
4 years, 1 month ago by Florian Schneider

Modified:
4 years, 1 month ago

Reviewers:
zra

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

DBC: Fix bugs with array allocation Guard against negative length in the fast path. Add missing PC descriptors for correct exceptions. BUG= R=zra@google.com Committed: https://github.com/dart-lang/sdk/commit/368409d3e41df4ac2153f04949e4ea121c423e04

Created: 4 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+29 lines, -3 lines)			Patch
M	runtime/vm/intermediate_language_dbc.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/simulator_dbc.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
A	tests/language/vm/optimized_list_constructor_test.dart	View	1 chunk	+26 lines, -0 lines	0 comments	Download

Total messages: 5 (2 generated)

Florian Schneider

4 years, 1 month ago (2016-11-08 23:45:36 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
368409d3e41df4ac2153f04949e4ea121c423e04 (presubmit successful).