OLD | NEW |
1 # Copyright 2012 the V8 project authors. All rights reserved. | 1 # Copyright 2012 the V8 project authors. All rights reserved. |
2 # Redistribution and use in source and binary forms, with or without | 2 # Redistribution and use in source and binary forms, with or without |
3 # modification, are permitted provided that the following conditions are | 3 # modification, are permitted provided that the following conditions are |
4 # met: | 4 # met: |
5 # | 5 # |
6 # * Redistributions of source code must retain the above copyright | 6 # * Redistributions of source code must retain the above copyright |
7 # notice, this list of conditions and the following disclaimer. | 7 # notice, this list of conditions and the following disclaimer. |
8 # * Redistributions in binary form must reproduce the above | 8 # * Redistributions in binary form must reproduce the above |
9 # copyright notice, this list of conditions and the following | 9 # copyright notice, this list of conditions and the following |
10 # disclaimer in the documentation and/or other materials provided | 10 # disclaimer in the documentation and/or other materials provided |
(...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
60 'not perfect. The commit queue will not block on this warning.') | 60 'not perfect. The commit queue will not block on this warning.') |
61 | 61 |
62 | 62 |
63 def _V8PresubmitChecks(input_api, output_api): | 63 def _V8PresubmitChecks(input_api, output_api): |
64 """Runs the V8 presubmit checks.""" | 64 """Runs the V8 presubmit checks.""" |
65 import sys | 65 import sys |
66 sys.path.append(input_api.os_path.join( | 66 sys.path.append(input_api.os_path.join( |
67 input_api.PresubmitLocalPath(), 'tools')) | 67 input_api.PresubmitLocalPath(), 'tools')) |
68 from presubmit import CppLintProcessor | 68 from presubmit import CppLintProcessor |
69 from presubmit import SourceProcessor | 69 from presubmit import SourceProcessor |
70 from presubmit import CheckExternalReferenceRegistration | |
71 from presubmit import CheckAuthorizedAuthor | 70 from presubmit import CheckAuthorizedAuthor |
72 from presubmit import CheckStatusFiles | 71 from presubmit import CheckStatusFiles |
73 | 72 |
74 results = [] | 73 results = [] |
75 if not CppLintProcessor().Run(input_api.PresubmitLocalPath()): | 74 if not CppLintProcessor().Run(input_api.PresubmitLocalPath()): |
76 results.append(output_api.PresubmitError("C++ lint check failed")) | 75 results.append(output_api.PresubmitError("C++ lint check failed")) |
77 if not SourceProcessor().Run(input_api.PresubmitLocalPath()): | 76 if not SourceProcessor().Run(input_api.PresubmitLocalPath()): |
78 results.append(output_api.PresubmitError( | 77 results.append(output_api.PresubmitError( |
79 "Copyright header, trailing whitespaces and two empty lines " \ | 78 "Copyright header, trailing whitespaces and two empty lines " \ |
80 "between declarations check failed")) | 79 "between declarations check failed")) |
81 if not CheckExternalReferenceRegistration(input_api.PresubmitLocalPath()): | |
82 results.append(output_api.PresubmitError( | |
83 "External references registration check failed")) | |
84 if not CheckStatusFiles(input_api.PresubmitLocalPath()): | 80 if not CheckStatusFiles(input_api.PresubmitLocalPath()): |
85 results.append(output_api.PresubmitError("Status file check failed")) | 81 results.append(output_api.PresubmitError("Status file check failed")) |
86 results.extend(CheckAuthorizedAuthor(input_api, output_api)) | 82 results.extend(CheckAuthorizedAuthor(input_api, output_api)) |
87 return results | 83 return results |
88 | 84 |
89 | 85 |
90 def _CheckUnwantedDependencies(input_api, output_api): | 86 def _CheckUnwantedDependencies(input_api, output_api): |
91 """Runs checkdeps on #include statements added in this | 87 """Runs checkdeps on #include statements added in this |
92 change. Breaking - rules is an error, breaking ! rules is a | 88 change. Breaking - rules is an error, breaking ! rules is a |
93 warning. | 89 warning. |
(...skipping 192 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
286 def CheckChangeOnCommit(input_api, output_api): | 282 def CheckChangeOnCommit(input_api, output_api): |
287 results = [] | 283 results = [] |
288 results.extend(_CommonChecks(input_api, output_api)) | 284 results.extend(_CommonChecks(input_api, output_api)) |
289 results.extend(input_api.canned_checks.CheckChangeHasDescription( | 285 results.extend(input_api.canned_checks.CheckChangeHasDescription( |
290 input_api, output_api)) | 286 input_api, output_api)) |
291 if not _SkipTreeCheck(input_api, output_api): | 287 if not _SkipTreeCheck(input_api, output_api): |
292 results.extend(input_api.canned_checks.CheckTreeIsOpen( | 288 results.extend(input_api.canned_checks.CheckTreeIsOpen( |
293 input_api, output_api, | 289 input_api, output_api, |
294 json_url='http://v8-status.appspot.com/current?format=json')) | 290 json_url='http://v8-status.appspot.com/current?format=json')) |
295 return results | 291 return results |
OLD | NEW |