Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: content/renderer/media/android/webmediaplayer_android.h

Issue 2490783002: Refactor WebMediaPlayerDelegate interface. (Closed)
Patch Set: Unit tests. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/renderer/media/android/webmediaplayer_android.cc » ('j') | content/renderer/media/android/webmediaplayer_android.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/media/android/webmediaplayer_android.h
diff --git a/content/renderer/media/android/webmediaplayer_android.h b/content/renderer/media/android/webmediaplayer_android.h
index c54acd359e832d5e713095bacbef0ff04f10b7db..1a141f246f43a38d8327b80675240f0b5ef7dc89 100644
--- a/content/renderer/media/android/webmediaplayer_android.h
+++ b/content/renderer/media/android/webmediaplayer_android.h
@@ -214,9 +214,10 @@ class WebMediaPlayerAndroid
void SuspendAndReleaseResources() override;
// WebMediaPlayerDelegate::Observer implementation.
- void OnHidden() override;
- void OnShown() override;
- bool OnSuspendRequested(bool must_suspend) override;
+ void OnFrameHidden() override;
+ void OnFrameClosed() override;
+ void OnFrameShown() override;
watk 2016/12/10 00:01:30 This is great
+ bool OnIdleTimeout() override;
void OnPlay() override;
void OnPause() override;
void OnVolumeMultiplierUpdate(double multiplier) override;
« no previous file with comments | « no previous file | content/renderer/media/android/webmediaplayer_android.cc » ('j') | content/renderer/media/android/webmediaplayer_android.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698