Issue 2490713003: Add "PasswordManager.SignInPromoDismissalCount" histogram.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2490713003: Add "PasswordManager.SignInPromoDismissalCount" histogram. (Closed)

Created:
4 years, 1 month ago by vasilii

Modified:
4 years, 1 month ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/2883

Project:
chromium

Visibility:
Public.

Add "PasswordManager.SignInPromoDismissalCount" histogram. It measures number of times the user dismissed the sign-in promo in the password bubble. BUG=662432 Review-Url: https://codereview.chromium.org/2481453002 Cr-Commit-Position: refs/heads/master@{#430575} (cherry picked from commit 96dc6b4f71706f04a41e2abe3af204529c535c14) Committed: https://chromium.googlesource.com/chromium/src/+/7d3ad4997b022d4a9ff50e79f162cf8a1bd220d1

Created: 4 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+36 lines, -6 lines)			Patch
M	chrome/browser/ui/passwords/manage_passwords_bubble_model.cc	View	5 chunks	+16 lines, -6 lines	0 comments	Download
M	chrome/browser/ui/passwords/manage_passwords_bubble_model_unittest.cc	View	5 chunks	+12 lines, -0 lines	0 comments	Download
M	tools/metrics/histograms/histograms.xml	View	1 chunk	+8 lines, -0 lines	0 comments	Download

Total messages: 2 (1 generated)

vasilii

4 years, 1 month ago (2016-11-09 21:01:27 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
7d3ad4997b022d4a9ff50e79f162cf8a1bd220d1.