Make Pepper use Mojo-based support for media-device enumeration and monitoring.

Make Pepper use Mojo-based support for media-device enumeration and monitoring.

BUG=648183
Committed: https://crrev.com/803b98a1aa125513dea0e35ef84796ffaac17ff3
Cr-Commit-Position: refs/heads/master@{#431332}

[Guido Urdaneta, 2016-11-08 16:29:20]

guidou@chromium.org changed reviewers:
+ bbudge@chromium.org

[Guido Urdaneta, 2016-11-08 16:29:20]

Hi, PTAL

[Guido Urdaneta, 2016-11-08 16:29:25]

The CQ bit was checked by guidou@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-08 16:29:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-08 18:22:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-08 18:22:56]

Dry run: This issue passed the CQ dry run.

[Guido Urdaneta, 2016-11-10 10:01:59]

Patchset #1 (id:1) has been deleted

[bbudge, 2016-11-10 18:38:55]

A couple of comments. I'm not knowledgeable with device enumeration but overall
LGTM.

https://codereview.chromium.org/2490653002/diff/20001/content/renderer/pepper...
File content/renderer/pepper/pepper_device_enumeration_host_helper.cc (right):

https://codereview.chromium.org/2490653002/diff/20001/content/renderer/pepper...
content/renderer/pepper/pepper_device_enumeration_host_helper.cc:74:
PepperDeviceEnumerationHostHelper* owner_;
This isn't used outside of the constructor. Can we get rid of it?

https://codereview.chromium.org/2490653002/diff/20001/content/renderer/pepper...
content/renderer/pepper/pepper_device_enumeration_host_helper.cc:107: if
(requested_ && owner_->delegate_) {
Maybe DCHECK(owner) here?

[Guido Urdaneta, 2016-11-10 19:01:17]

https://codereview.chromium.org/2490653002/diff/20001/content/renderer/pepper...
File content/renderer/pepper/pepper_device_enumeration_host_helper.cc (right):

https://codereview.chromium.org/2490653002/diff/20001/content/renderer/pepper...
content/renderer/pepper/pepper_device_enumeration_host_helper.cc:74:
PepperDeviceEnumerationHostHelper* owner_;
On 2016/11/10 18:38:55, bbudge wrote:
> This isn't used outside of the constructor. Can we get rid of it?

Done.

https://codereview.chromium.org/2490653002/diff/20001/content/renderer/pepper...
content/renderer/pepper/pepper_device_enumeration_host_helper.cc:107: if
(requested_ && owner_->delegate_) {
On 2016/11/10 18:38:54, bbudge wrote:
> Maybe DCHECK(owner) here?

Added DCHECK in constructor and made the field const.

[Guido Urdaneta, 2016-11-10 19:01:54]

The CQ bit was checked by guidou@chromium.org

[Guido Urdaneta, 2016-11-10 19:01:54]

The patchset sent to the CQ was uploaded after l-g-t-m from bbudge@chromium.org
Link to the patchset: https://codereview.chromium.org/2490653002/#ps40001
(title: "address bbudge's comments")

[commit-bot: I haz the power, 2016-11-10 19:02:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-10 20:08:11]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-11-10 20:14:26]

Description was changed from

==========
Make Pepper use Mojo-based support for media-device enumeration and monitoring.

BUG=648183
==========

to

==========
Make Pepper use Mojo-based support for media-device enumeration and monitoring.

BUG=648183

Committed: https://crrev.com/803b98a1aa125513dea0e35ef84796ffaac17ff3
Cr-Commit-Position: refs/heads/master@{#431332}
==========

[commit-bot: I haz the power, 2016-11-10 20:14:27]

Patchset 2 (id:??) landed as
https://crrev.com/803b98a1aa125513dea0e35ef84796ffaac17ff3
Cr-Commit-Position: refs/heads/master@{#431332}