Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 249063003: Revert of Remove remaining window states where window is shown with opacity 0. (Closed)

Created:
6 years, 8 months ago by James Cook
Modified:
6 years, 8 months ago
CC:
chromium-reviews, sadrul, yusukes+watch_chromium.org, derat+watch_chromium.org, ben+aura_chromium.org, mazda+watch_chromium.org, kalyank, ben+ash_chromium.org
Visibility:
Public.

Description

Revert of Remove remaining window states where window is shown with opacity 0. (https://codereview.chromium.org/237963019/) Reason for revert: Causing browser_test failures on main waterfall, probably due to shelf animations: EnterpriseKioskApp AutolaunchWarningCancel AutolaunchWarningConfirm KioskEnableCancel KioskEnableConfirmed See crbug.com/366142 for stacks. Original issue's description: > Remove remaining window states where window is shown with opacity 0. > > BUG=351553 > TEST=Unit tests pass, can enter overview mode and show/hide panels in debug mode without triggering DCHECK in window.cc. > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=265330 TBR=sky@chromium.org,skuhne@chromium.org,flackr@chromium.org NOTREECHECKS=true NOTRY=true BUG=351553 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=265660

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -58 lines) Patch
M ash/shelf/shelf_util.h View 1 chunk +0 lines, -5 lines 0 comments Download
M ash/shelf/shelf_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/overview/window_overview.cc View 4 chunks +4 lines, -6 lines 0 comments Download
M ash/wm/panels/panel_layout_manager.h View 4 chunks +4 lines, -11 lines 0 comments Download
M ash/wm/panels/panel_layout_manager.cc View 8 chunks +17 lines, -29 lines 0 comments Download
M ash/wm/panels/panel_layout_manager_unittest.cc View 4 chunks +7 lines, -5 lines 0 comments Download
M ash/wm/panels/panel_window_resizer_unittest.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/aura/window.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
James Cook
Created Revert of Remove remaining window states where window is shown with opacity 0.
6 years, 8 months ago (2014-04-23 16:06:15 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/249063003/1
6 years, 8 months ago (2014-04-23 16:06:21 UTC) #2
commit-bot: I haz the power
Change committed as 265660
6 years, 8 months ago (2014-04-23 16:07:13 UTC) #3
James Cook
6 years, 8 months ago (2014-04-23 16:14:36 UTC) #4
Message was sent while issue was closed.
On 2014/04/23 16:07:13, I haz the power (commit-bot) wrote:
> Change committed as 265660

Sorry, wrong test list. It was actually these:
EnterpriseKioskApp
AutolaunchWarningConfirm
InstallAndLaunchApp
LaunchAppNetworkDown
...

Powered by Google App Engine
This is Rietveld 408576698