Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1939)

Unified Diff: content/renderer/render_thread_impl.cc

Issue 2490623005: Remove InterfaceRegistry/Provider from service workers (Closed)
Patch Set: review Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_thread_impl.cc
diff --git a/content/renderer/render_thread_impl.cc b/content/renderer/render_thread_impl.cc
index 43eefcb8988766e64ee517f00152423646d38c92..67ee29d5d8ed732fd673d8b6c1814ef35e2d913c 100644
--- a/content/renderer/render_thread_impl.cc
+++ b/content/renderer/render_thread_impl.cc
@@ -375,8 +375,7 @@ void CreateFrameFactory(mojom::FrameFactoryRequest request) {
}
void SetupEmbeddedWorkerOnWorkerThread(
- service_manager::mojom::InterfaceProviderRequest request,
- service_manager::mojom::InterfaceProviderPtrInfo remote_interfaces) {
+ mojom::ServiceWorkerEventDispatcherRequest request) {
ServiceWorkerContextClient* client =
ServiceWorkerContextClient::ThreadSpecificInstance();
// It is possible for client to be null if for some reason the worker died
@@ -384,22 +383,19 @@ void SetupEmbeddedWorkerOnWorkerThread(
// nothing and let mojo close the connection.
if (!client)
return;
- client->BindInterfaceProviders(std::move(request),
- mojo::MakeProxy(std::move(remote_interfaces)));
+ client->BindEventDispatcher(std::move(request));
}
class EmbeddedWorkerSetupImpl : public mojom::EmbeddedWorkerSetup {
public:
EmbeddedWorkerSetupImpl() = default;
- void ExchangeInterfaceProviders(
+ void AttachServiceWorkerEventDispatcher(
int32_t thread_id,
- service_manager::mojom::InterfaceProviderRequest request,
- service_manager::mojom::InterfaceProviderPtr remote_interfaces) override {
+ mojom::ServiceWorkerEventDispatcherRequest request) override {
WorkerThreadRegistry::Instance()->GetTaskRunnerFor(thread_id)->PostTask(
FROM_HERE,
- base::Bind(&SetupEmbeddedWorkerOnWorkerThread, base::Passed(&request),
- base::Passed(remote_interfaces.PassInterface())));
+ base::Bind(&SetupEmbeddedWorkerOnWorkerThread, base::Passed(&request)));
}
};

Powered by Google App Engine
This is Rietveld 408576698