Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1085)

Unified Diff: third_party/WebKit/Source/modules/peerconnection/RTCSessionDescription.idl

Issue 2490543002: Measure usage of RTCSessionDescription's type and sdp attributes (Closed)
Patch Set: add missing "be" Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/peerconnection/RTCSessionDescription.idl
diff --git a/third_party/WebKit/Source/modules/peerconnection/RTCSessionDescription.idl b/third_party/WebKit/Source/modules/peerconnection/RTCSessionDescription.idl
index ce4c3a0407c8fd034d37053e4318faace6423a4c..1ae9679a5b28b9e9c0a496de7b84082846ba3f87 100644
--- a/third_party/WebKit/Source/modules/peerconnection/RTCSessionDescription.idl
+++ b/third_party/WebKit/Source/modules/peerconnection/RTCSessionDescription.idl
@@ -28,18 +28,22 @@
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
-// http://www.w3.org/TR/webrtc/#idl-def-RTCSessionDescription
+// https://w3c.github.io/webrtc-pc/#rtcsessiondescription-class
enum RTCSdpType {
"offer",
"pranswer",
"answer"
+ // TODO(foolip): "rollback" is in the spec and Gecko's IDL.
};
[
- Constructor(optional RTCSessionDescriptionInit descriptionInitDict)
+ Constructor(optional RTCSessionDescriptionInit descriptionInitDict),
+ ConstructorCallWith=ExecutionContext,
] interface RTCSessionDescription {
- attribute RTCSdpType? type;
- attribute DOMString? sdp;
+ // TODO(foolip): |type| and |sdp| should be readonly and not nullable.
+ // https://crbug.com/662898
+ [Measure] attribute RTCSdpType? type;
+ [Measure] attribute DOMString? sdp;
serializer = {attribute};
};

Powered by Google App Engine
This is Rietveld 408576698