Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Issue 2490543002: Measure usage of RTCSessionDescription's type and sdp attributes (Closed)

Created:
4 years, 1 month ago by foolip
Modified:
4 years, 1 month ago
CC:
asvitkine+watch_chromium.org, blink-reviews, chromium-reviews, haraken
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Measure usage of RTCSessionDescription's type and sdp attributes Also measure missing members in the init dict, that is how the members would end up as null, and will show how often adding required would throw a TypeError due to missing type. BUG=662898 R=guidou@chromium.org Committed: https://crrev.com/3fdd951cdccbd48de88767e6156bad40ff52738d Cr-Commit-Position: refs/heads/master@{#430662}

Patch Set 1 #

Patch Set 2 : measure init dict too #

Patch Set 3 : add missing "be" #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -6 lines) Patch
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/peerconnection/RTCSessionDescription.h View 1 2 chunks +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/peerconnection/RTCSessionDescription.cpp View 1 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/peerconnection/RTCSessionDescription.idl View 1 2 1 chunk +8 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/peerconnection/RTCSessionDescriptionInit.idl View 1 chunk +2 lines, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (10 generated)
foolip
4 years, 1 month ago (2016-11-08 11:01:11 UTC) #1
Guido Urdaneta
lgtm
4 years, 1 month ago (2016-11-08 11:06:29 UTC) #4
foolip
On 2016/11/08 11:06:29, Guido Urdaneta wrote: > lgtm Sorry, I realized there was something more ...
4 years, 1 month ago (2016-11-08 11:18:23 UTC) #6
Guido Urdaneta
lgtm
4 years, 1 month ago (2016-11-08 11:19:43 UTC) #7
Mike West
histograms.xml LGTM
4 years, 1 month ago (2016-11-08 11:31:19 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2490543002/40001
4 years, 1 month ago (2016-11-08 11:48:04 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/327669)
4 years, 1 month ago (2016-11-08 16:28:20 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2490543002/40001
4 years, 1 month ago (2016-11-08 16:34:08 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-11-08 18:29:57 UTC) #18
commit-bot: I haz the power
4 years, 1 month ago (2016-11-08 18:38:51 UTC) #20
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/3fdd951cdccbd48de88767e6156bad40ff52738d
Cr-Commit-Position: refs/heads/master@{#430662}

Powered by Google App Engine
This is Rietveld 408576698