[wasm] Always trap for memory accesses with offset=uint32_max.

[wasm] Always trap for memory accesses with offset=uint32_max.

We handle this case specially because otherwise we would have to do
complicated overflow detection.

R=titzer@chromium.org
TEST=cctest/test-run-wasm/RunWasmCompiled_LoadMaxUint32Offset

Committed: https://crrev.com/387817f5bb1337d37a09ec0fd789b28d4b3a0bd1
Cr-Commit-Position: refs/heads/master@{#40844}

[ahaas, 2016-11-08 15:07:35]

The CQ bit was checked by ahaas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-08 15:07:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-08 15:12:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-08 15:12:56]

Dry run: Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)

[titzer, 2016-11-08 15:16:32]

lgtm

https://codereview.chromium.org/2490533003/diff/1/src/compiler/wasm-compiler.cc
File src/compiler/wasm-compiler.cc (right):

https://codereview.chromium.org/2490533003/diff/1/src/compiler/wasm-compiler....
src/compiler/wasm-compiler.cc:2925: (offset - 1) + memsize;  // == offset +
memsize - 1
comment is probably unnecessary

https://codereview.chromium.org/2490533003/diff/1/test/cctest/wasm/test-run-w...
File test/cctest/wasm/test-run-wasm.cc (right):

https://codereview.chromium.org/2490533003/diff/1/test/cctest/wasm/test-run-w...
test/cctest/wasm/test-run-wasm.cc:1120: 0,                                  //
alignement
alignment

[ahaas, 2016-11-08 15:18:28]

The CQ bit was checked by ahaas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-08 15:18:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-08 15:44:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-08 15:44:34]

Dry run: This issue passed the CQ dry run.

[ahaas, 2016-11-08 15:44:57]

The CQ bit was checked by ahaas@chromium.org

[ahaas, 2016-11-08 15:44:58]

The patchset sent to the CQ was uploaded after l-g-t-m from titzer@chromium.org
Link to the patchset: https://codereview.chromium.org/2490533003/#ps20001
(title: "Remove unused variable, address comments")

[commit-bot: I haz the power, 2016-11-08 15:45:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-08 15:47:03]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-17 22:26:35]

Description was changed from

==========
[wasm] Always trap for memory accesses with offset=uint32_max.

We handle this case specially because otherwise we would have to do
complicated overflow detection.

R=titzer@chromium.org
TEST=cctest/test-run-wasm/RunWasmCompiled_LoadMaxUint32Offset
==========

to

==========
[wasm] Always trap for memory accesses with offset=uint32_max.

We handle this case specially because otherwise we would have to do
complicated overflow detection.

R=titzer@chromium.org
TEST=cctest/test-run-wasm/RunWasmCompiled_LoadMaxUint32Offset

Committed: https://crrev.com/387817f5bb1337d37a09ec0fd789b28d4b3a0bd1
Cr-Commit-Position: refs/heads/master@{#40844}
==========

[commit-bot: I haz the power, 2016-11-17 22:26:38]

Patchset 2 (id:??) landed as
https://crrev.com/387817f5bb1337d37a09ec0fd789b28d4b3a0bd1
Cr-Commit-Position: refs/heads/master@{#40844}