Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(533)

Issue 2490533002: Ozone documentation: Take into account recent changes in Linux Desktop (Closed)

Created:
4 years, 1 month ago by fwang
Modified:
4 years, 1 month ago
Reviewers:
tonikitoo
CC:
chromium-reviews, rjkroege, Tom (Use chromium acct), joone
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Ozone documentation: Take into account recent changes in Linux Desktop BUG=295089 Committed: https://crrev.com/15744c760b64d09988003601596ed16bad40df6f Cr-Commit-Position: refs/heads/master@{#430599}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Remove content_shell from working Linux Desktop targets. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -11 lines) Patch
M docs/ozone_overview.md View 1 2 chunks +28 lines, -11 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
fwang
PTAL
4 years, 1 month ago (2016-11-08 10:13:20 UTC) #2
tonikitoo
lgtm with minor changes. https://codereview.chromium.org/2490533002/diff/1/docs/ozone_overview.md File docs/ozone_overview.md (right): https://codereview.chromium.org/2490533002/diff/1/docs/ozone_overview.md#newcode169 docs/ozone_overview.md:169: * `content_shell` lets omit content_shell ...
4 years, 1 month ago (2016-11-08 13:09:22 UTC) #4
fwang
https://codereview.chromium.org/2490533002/diff/1/docs/ozone_overview.md File docs/ozone_overview.md (right): https://codereview.chromium.org/2490533002/diff/1/docs/ozone_overview.md#newcode169 docs/ozone_overview.md:169: * `content_shell` On 2016/11/08 13:09:21, tonikitoo wrote: > lets ...
4 years, 1 month ago (2016-11-08 13:12:18 UTC) #5
tonikitoo
lgtm
4 years, 1 month ago (2016-11-08 13:41:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2490533002/20001
4 years, 1 month ago (2016-11-08 13:42:03 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-08 13:59:01 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-08 14:02:48 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/15744c760b64d09988003601596ed16bad40df6f
Cr-Commit-Position: refs/heads/master@{#430599}

Powered by Google App Engine
This is Rietveld 408576698