Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 2490523003: [heap] Use size_t for heap and space counters. (Closed)

Created:
4 years, 1 month ago by ulan
Modified:
4 years, 1 month ago
Reviewers:
Michael Lippautz
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan, Michael Achenbach
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Use size_t for heap and space counters. BUG=chromium:652721 Committed: https://crrev.com/71a7bca990c557a7106fa89ab6bff08b09e3b243 Cr-Commit-Position: refs/heads/master@{#40972}

Patch Set 1 #

Patch Set 2 : 1 #

Patch Set 3 : more fixes #

Patch Set 4 : more fixes #

Patch Set 5 : more fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+258 lines, -265 lines) Patch
M src/extensions/statistics-extension.cc View 2 chunks +14 lines, -19 lines 0 comments Download
M src/heap/gc-tracer.cc View 1 2 3 3 chunks +5 lines, -7 lines 0 comments Download
M src/heap/heap.h View 1 2 12 chunks +43 lines, -52 lines 0 comments Download
M src/heap/heap.cc View 1 2 3 4 22 chunks +94 lines, -97 lines 0 comments Download
M src/heap/spaces.h View 1 2 19 chunks +48 lines, -41 lines 0 comments Download
M src/heap/spaces.cc View 1 2 12 chunks +28 lines, -29 lines 0 comments Download
M src/heap/spaces-inl.h View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M src/ia32/assembler-ia32.cc View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M src/objects-debug.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M src/x64/assembler-x64.cc View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M src/x87/assembler-x87.cc View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M test/cctest/heap/test-alloc.cc View 1 2 1 chunk +6 lines, -4 lines 0 comments Download
M test/cctest/heap/test-heap.cc View 1 2 4 chunks +6 lines, -4 lines 0 comments Download
M test/cctest/heap/test-spaces.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-api.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (13 generated)
ulan
ptal
4 years, 1 month ago (2016-11-14 16:03:09 UTC) #7
Michael Lippautz
lgtm
4 years, 1 month ago (2016-11-14 16:39:05 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2490523003/80001
4 years, 1 month ago (2016-11-14 16:39:37 UTC) #14
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 1 month ago (2016-11-14 16:46:52 UTC) #16
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:32:59 UTC) #18
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/71a7bca990c557a7106fa89ab6bff08b09e3b243
Cr-Commit-Position: refs/heads/master@{#40972}

Powered by Google App Engine
This is Rietveld 408576698