Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 249048: Add "copy" to context menu on bookmark button.... (Closed)

Created:
11 years, 2 months ago by John Grabowski
Modified:
9 years, 6 months ago
Reviewers:
jeremy
CC:
chromium-reviews_googlegroups.com, John Grabowski, pam+watch_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

Add "copy" to context menu on bookmark button. BUG=http://crbug.com/16941 TEST=Right-click on bookmark button; pick copy. Go to any other app and paste. Make sure you got URL. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27690

Patch Set 1 #

Total comments: 8

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+550 lines, -38 lines) Patch
M chrome/app/nibs/BookmarkBar.xib View 1 24 chunks +537 lines, -38 lines 0 comments Download
M chrome/browser/cocoa/bookmark_bar_controller.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/cocoa/bookmark_bar_controller.mm View 1 2 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
John Grabowski
11 years, 2 months ago (2009-09-30 22:43:55 UTC) #1
jeremy
http://codereview.chromium.org/249048/diff/1/2 File chrome/app/nibs/BookmarkBar.xib (right): http://codereview.chromium.org/249048/diff/1/2#newcode86 Line 86: <double key="NSSize">13</double> hmm.... http://codereview.chromium.org/249048/diff/1/3 File chrome/browser/cocoa/bookmark_bar_controller.mm (right): http://codereview.chromium.org/249048/diff/1/3#newcode395 ...
11 years, 2 months ago (2009-09-30 22:53:33 UTC) #2
John Grabowski
http://codereview.chromium.org/249048/diff/1/2 File chrome/app/nibs/BookmarkBar.xib (right): http://codereview.chromium.org/249048/diff/1/2#newcode86 Line 86: <double key="NSSize">13</double> On 2009/09/30 22:53:34, jeremy wrote: > ...
11 years, 2 months ago (2009-09-30 23:36:33 UTC) #3
jeremy
LGTM http://codereview.chromium.org/249048/diff/1/3 File chrome/browser/cocoa/bookmark_bar_controller.mm (right): http://codereview.chromium.org/249048/diff/1/3#newcode400 Line 400: [pasteboard setDataForURL:url title:title]; I'm just wondering if ...
11 years, 2 months ago (2009-09-30 23:40:33 UTC) #4
John Grabowski
http://codereview.chromium.org/249048/diff/1/3 File chrome/browser/cocoa/bookmark_bar_controller.mm (right): http://codereview.chromium.org/249048/diff/1/3#newcode400 Line 400: [pasteboard setDataForURL:url title:title]; On 2009/09/30 23:40:36, jeremy wrote: ...
11 years, 2 months ago (2009-09-30 23:57:05 UTC) #5
John Grabowski
11 years, 2 months ago (2009-10-01 00:07:51 UTC) #6
http://crbug.com/23509

On Wed, Sep 30, 2009 at 4:57 PM, <jrg@chromium.org> wrote:

>
> http://codereview.chromium.org/249048/diff/1/3
> File chrome/browser/cocoa/bookmark_bar_controller.mm (right):
>
> http://codereview.chromium.org/249048/diff/1/3#newcode400
> Line 400: [pasteboard setDataForURL:url title:title];
> On 2009/09/30 23:40:36, jeremy wrote:
>
>> I'm just wondering if we want to change base/clipboard.h to use this?
>>
> I think
>
>> that's what that function is supposed to do...
>>
>
> Probably, although I don't know if it's OK for base to depend on
> third_party like that.  I will file a bug as follow-up.
>
>
> http://codereview.chromium.org/249048
>

Powered by Google App Engine
This is Rietveld 408576698