Add "copy" to context menu on bookmark button....

Add "copy" to context menu on bookmark button.

BUG=http://crbug.com/16941
TEST=Right-click on bookmark button; pick copy.
  Go to any other app and paste.  Make sure you got URL.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27690

[jeremy, 2009-09-30 22:53:33]

http://codereview.chromium.org/249048/diff/1/2
File chrome/app/nibs/BookmarkBar.xib (right):

http://codereview.chromium.org/249048/diff/1/2#newcode86
Line 86: <double key="NSSize">13</double>
hmm....

http://codereview.chromium.org/249048/diff/1/3
File chrome/browser/cocoa/bookmark_bar_controller.mm (right):

http://codereview.chromium.org/249048/diff/1/3#newcode395
Line 395: NSString* url = [NSString stringWithUTF8String:spec.c_str()];
nit: base::SysUTF8ToNSString ?

http://codereview.chromium.org/249048/diff/1/3#newcode400
Line 400: [pasteboard setDataForURL:url title:title];
Perhaps use Clipboard::WriteBookmark() in base/clipboard.h

[John Grabowski, 2009-09-30 23:36:33]

http://codereview.chromium.org/249048/diff/1/2
File chrome/app/nibs/BookmarkBar.xib (right):

http://codereview.chromium.org/249048/diff/1/2#newcode86
Line 86: <double key="NSSize">13</double>
On 2009/09/30 22:53:34, jeremy wrote:
> hmm....

I didn't change font anything, and don't see any visual font size change.
This is all IB.
(If anything, looks like the previous entry of 1.3 is the wrong one...)

http://codereview.chromium.org/249048/diff/1/3
File chrome/browser/cocoa/bookmark_bar_controller.mm (right):

http://codereview.chromium.org/249048/diff/1/3#newcode395
Line 395: NSString* url = [NSString stringWithUTF8String:spec.c_str()];
On 2009/09/30 22:53:34, jeremy wrote:
> nit: base::SysUTF8ToNSString ?

Changed

http://codereview.chromium.org/249048/diff/1/3#newcode400
Line 400: [pasteboard setDataForURL:url title:title];
On 2009/09/30 22:53:34, jeremy wrote:
> Perhaps use Clipboard::WriteBookmark() in base/clipboard.h

Not good enough; I want both URL and text on pasteboard, which this call does
for me (In NSPasteboard+Utils.mm).

[jeremy, 2009-09-30 23:40:33]

LGTM

http://codereview.chromium.org/249048/diff/1/3
File chrome/browser/cocoa/bookmark_bar_controller.mm (right):

http://codereview.chromium.org/249048/diff/1/3#newcode400
Line 400: [pasteboard setDataForURL:url title:title];
I'm just wondering if we want to change base/clipboard.h to use this?  I think
that's what that function is supposed to do...

[John Grabowski, 2009-09-30 23:57:05]

http://codereview.chromium.org/249048/diff/1/3
File chrome/browser/cocoa/bookmark_bar_controller.mm (right):

http://codereview.chromium.org/249048/diff/1/3#newcode400
Line 400: [pasteboard setDataForURL:url title:title];
On 2009/09/30 23:40:36, jeremy wrote:
> I'm just wondering if we want to change base/clipboard.h to use this?  I think
> that's what that function is supposed to do...

Probably, although I don't know if it's OK for base to depend on third_party
like that.  I will file a bug as follow-up.

[John Grabowski, 2009-10-01 00:07:51]

http://crbug.com/23509

On Wed, Sep 30, 2009 at 4:57 PM, <jrg@chromium.org> wrote:

>
> http://codereview.chromium.org/249048/diff/1/3
> File chrome/browser/cocoa/bookmark_bar_controller.mm (right):
>
> http://codereview.chromium.org/249048/diff/1/3#newcode400
> Line 400: [pasteboard setDataForURL:url title:title];
> On 2009/09/30 23:40:36, jeremy wrote:
>
>> I'm just wondering if we want to change base/clipboard.h to use this?
>>
> I think
>
>> that's what that function is supposed to do...
>>
>
> Probably, although I don't know if it's OK for base to depend on
> third_party like that.  I will file a bug as follow-up.
>
>
> http://codereview.chromium.org/249048
>